Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW RULE] Adding no-async-actions rule [DO NOT MERGE] #424

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

[NEW RULE] Adding no-async-actions rule [DO NOT MERGE] #424

wants to merge 9 commits into from

Commits on May 25, 2019

  1. [NEW RULE] Adding no-async-actions rule 

    Fixes ember-cli#418

[DO NOT MERGE]
1. Working for normal async actions
2. With decorators it is throwing errors, need to fix this.
    @rajasegar
    rajasegar committed May 25, 2019
    Configuration menu
    Copy the full SHA
    24ebede View commit details
    Browse the repository at this point in the history

Commits on May 29, 2019

  1. [DOCS] Adding doc pages for the rule 

    1. Also adding the rule to the Best practices section in README
    @rajasegar
    rajasegar committed May 29, 2019
    Configuration menu
    Copy the full SHA
    84ffc97 View commit details
    Browse the repository at this point in the history

  2. [BUG FIX] Typo fix in rule doc page

    @rajasegar
    rajasegar committed May 29, 2019
    Configuration menu
    Copy the full SHA
    a8dda02 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2019

  1. [CHORE] Review comments

    @rajasegar
    rajasegar committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    020b127 View commit details
    Browse the repository at this point in the history

  2. [CHORE] Yarn update rule no-async-actions

    @rajasegar
    rajasegar committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    efc6aaf View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2019

  1. Merge branch 'master' into no-async-actions

    @rajasegar
    rajasegar committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    8027f82 View commit details
    Browse the repository at this point in the history

  2. [CHORE] Address review comments 

    1. Make error message consistent across rules and tests
by reusing the same.
2. Added brief docs to the rules
    @rajasegar
    rajasegar committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    85e5e05 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2019

  1. [CHORE] Updating docs and adding babel-eslint parser 

    1. Update the rule docs with new brief
2. Add parser option to invalid tests as babel-eslint
    @rajasegar
    rajasegar committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    e849ad4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into no-async-actions

    @rajasegar
    rajasegar committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    80cc3aa View commit details
    Browse the repository at this point in the history