Update reportUnorderedProperties util function to also work with native classes
#574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurmurclar
force-pushed
the
lmc/native-order-in
branch
from
752b642
to
fdf69e2
Compare
tests/lib/utils/ember-test.js
Outdated
| export default Component.extend({ | ||
| levelOfHappiness: observer("attitude", "health", () => { | ||
| }), | ||
| vehicle: alias("car") |
There was a problem hiding this comment.
Is the vehicle prop here necessary for the test?
There was a problem hiding this comment.
🤦♀ Nope! Copy-pasta. Will update
tests/lib/utils/ember-test.js
Outdated
|
|
||
| it("should check if it's an observer prop", () => { | ||
| node = parse('observer()'); | ||
| context = new FauxContext(` |
There was a problem hiding this comment.
What do you think about splitting each of these different "types" into their one test cases? That would help make the test output more clear about where something is going wrong, if one of these cases no longer worked right.
There was a problem hiding this comment.
Yeah, it would generally be nice to have more, smaller unit tests.
bmish
reviewed
Nov 7, 2019
tests/lib/utils/ember-test.js
Outdated
|
|
||
| it("should check if it's an observer prop", () => { | ||
| node = parse('observer()'); | ||
| context = new FauxContext(` |
There was a problem hiding this comment.
Yeah, it would generally be nice to have more, smaller unit tests.
bmish
approved these changes
Nov 7, 2019
bmish
changed the title
reportUnorderedProperties to also work with native classes reportUnorderedProperties util function to also work with native classes
laurmurclar
force-pushed
the
lmc/native-order-in
branch
from
2fdd68d
to
6d4ed10
Compare
|
@bmish Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to unblock native class compatibility for the
order-in-*rules, which we want to fix (see #417)The
reportUnorderedPropertiesfunction relied on a bunch of utils which currently only work for "classic" classes. This PR adds functionality which also make them compatible with native classes.