Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: avoid using file name to determine class identity. #603

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

refactor: avoid using file name to determine class identity. #603

wants to merge 6 commits into from

Commits on Nov 21, 2019

  1. refactor: move module name helper into separate file

    @alexlafroscia
    alexlafroscia committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    a85b09a View commit details
    Browse the repository at this point in the history

  2. refactor: extract utility for getting import node

    @alexlafroscia
    alexlafroscia committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    d788c25 View commit details
    Browse the repository at this point in the history

  3. feat: add helper for checking if an Identifier is a default export

    @alexlafroscia
    alexlafroscia committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    d929f5e View commit details
    Browse the repository at this point in the history

  4. chore: update test cases to include imports

    @alexlafroscia
    alexlafroscia committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    39e3036 View commit details
    Browse the repository at this point in the history

  5. refactor: avoid using file name in rules 

    The original logic for determining if a Identifier was of a specific Ember class used the file name to make this decision, rather than resolving the import of the Identifier back to the Ember module it was imported from.

This ended up causing a number of issues in lint rule in cases where people places a class in a location that was unexpected based on Ember’s convention. Such issues include ember-cli#601 and ember-cli#430.

Making this change avoids the need for something like ember-cli#213, which adds additional logic based on file names to prevent some of these issues.

Closes ember-cli#590
    @alexlafroscia
    alexlafroscia committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    535cb40 View commit details
    Browse the repository at this point in the history

  6. test(require-tagless-components): add Service tests 

    Adding tests to validate ember-cli#601
    @alexlafroscia
    alexlafroscia committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    ba714c5 View commit details
    Browse the repository at this point in the history