Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for input-helper with action helper #503

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

les2
Copy link

@les2 les2 commented May 18, 2023

Add a test case showing that `{{action 'foo' value='target.foo'`` is preserved by the transform.

As discussed in the thread: https://discord.com/channels/480462759797063690/480462759797063692/1107915351829794836

an the angle-bracket codemod + ember-template-lint and i have some regressions related to (action 'foo' value='target.value') being transformed without including the value=target.value part.

example:

<Input
@input={{perform onInputTask value='target.value'}}

becomes:

<Input
{{on 'input' (perform onInputTask)}}

which breaks things.

Warning for anyone who tries ember-template-lint / angle-bracket-code-mod (not sure which is to blame).

I believe that the issue is actually caused by ember-template-lint and not this codemod.

I'm opening this to follow through on a promise made to open the test. It might not be necessary to merge it since the behavior is not caused by this repo to my knowledge.

Add a test case showing that `{{action 'foo' value='target.foo'`` is preserved by the transform.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant