Remove legacy Node.js support leftovers #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobisjan
force-pushed
the
node-cleanup
branch
2 times, most recently
from
398691e
to
9859a54
Compare
bobisjan
commented
Apr 12, 2020
| @@ -30,16 +30,12 @@ | |||
| "compression": "^1.6.2", | |||
| "express": "^4.13.3", | |||
| "fastboot": "^2.0.0", | |||
| "fastboot-express-middleware": "^2.0.0", | |||
| "fs-promise": "^2.0.3", | |||
bobisjan
commented
Apr 12, 2020
| @@ -30,16 +30,12 @@ | |||
| "compression": "^1.6.2", | |||
| "express": "^4.13.3", | |||
| "fastboot": "^2.0.0", | |||
| "fastboot-express-middleware": "^2.0.0", | |||
| "fs-promise": "^2.0.3", | |||
| "request": "^2.81.0" | |||
There was a problem hiding this comment.
This is required by request-promise for testing only.
bobisjan
changed the title
|
@rwjblue, would you take a look? |
rwjblue
approved these changes
Oct 24, 2020
| @@ -27,7 +27,7 @@ particular, you can provide a custom: | |||
|
|
|||
| ## Requirements | |||
|
|
|||
| FastBoot App Server requires Node.js v4.2 or later. | |||
| FastBoot App Server requires Node.js v8 or later. | |||
There was a problem hiding this comment.
Haha, I'd like to bump this again too but seems good to do separately...
There was a problem hiding this comment.
Yes 😬, #123 is the next step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes remaining leftovers of legacy Node.js support code #13.