Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom cache control headers for static assets #52

Closed
wants to merge 1 commit into from
Closed

Support custom cache control headers for static assets #52

wants to merge 1 commit into from

Conversation

sivakumar-kailasam
Copy link

Allows users to configure cache control for the static assets. Addresses #41

@sivakumar-kailasam
Copy link
Author

Another alternative could be passing an instance of https://github.com/expressjs/serve-static

@benkingcode
Copy link

Would love to get this in, I'd like my assets to be immutable rather than max-age=0. What is needed to get merged?

@mirague
Copy link

mirague commented Jun 19, 2017

Same here, max-age=0 makes no sense for static assets.

Also, possible duplicate of #35

@sivakumar-kailasam
Copy link
Author

Shucks, looks like #35 is much more flexible than this one, I can either improve or close this one in favor of it. Thoughts @arjansingh ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants