Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updated to reflect current Ember standards #1591

Merged
merged 1 commit into from Sep 20, 2021
Merged

fix: updated to reflect current Ember standards #1591

merged 1 commit into from Sep 20, 2021

Conversation

francispeixoto
Copy link

No description provided.

@longlho
Copy link
Collaborator

longlho commented Sep 9, 2021

Thanks a lot for your contributions!

@longlho
Copy link
Collaborator

longlho commented Sep 13, 2021

hmm looks like build is failing

@francispeixoto
Copy link
Author

@longlho looks like a known bug with eslint-plugin-ember that was fixed a while ago in their 8.10.1.

bug report: ember-cli/eslint-plugin-ember#905
pull request: ember-cli/eslint-plugin-ember#906
release: https://github.com/ember-cli/eslint-plugin-ember/releases/tag/v8.10.1

for reference, ember-intl is tagging 10.2.0 in master.

@longlho
Copy link
Collaborator

longlho commented Sep 20, 2021

Thanks a lot for your contributions!

@longlho longlho changed the title updated to reflect current Ember standards fix: updated to reflect current Ember standards Sep 20, 2021
@longlho longlho merged commit aa8ef98 into ember-intl:master Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@francispeixoto @longlho