Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCS: Fix migration test sample #1879

Merged
merged 2 commits into from
May 14, 2024
Merged

DOCS: Fix migration test sample #1879

merged 2 commits into from
May 14, 2024

Conversation

mkszepp
Copy link
Contributor

@mkszepp mkszepp commented May 14, 2024

In migration sample there the assert in language en is not correct. It should be Hello instead of Hallo

ijlee2
ijlee2 previously approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@ijlee2 ijlee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijlee2 ijlee2 merged commit ab21202 into ember-intl:main May 14, 2024
32 checks passed
@mkszepp mkszepp deleted the fix-migration-example branch May 14, 2024 07:10
@ijlee2 ijlee2 added the enhance: documentation Issue asks for better documentation (e.g. README, code, tests) label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijlee2 ijlee2 ijlee2 approved these changes

Assignees
No one assigned
Labels
enhance: documentation Issue asks for better documentation (e.g. README, code, tests)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mkszepp @ijlee2