Added @babel/core as a dependency (required by ember-cli-babel@v8) #1880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0965140.
…ng consumers to keep providing their own
ijlee2
force-pushed
the
add-missing-peer-dependencies
branch
from
0965140
to
e5bcaec
Compare
ijlee2
changed the title
ijlee2
approved these changes
May 14, 2024
There was a problem hiding this comment.
@mkszepp While I agree with the spirit of the RFC, I got the impression that auto-install-peers=false and resolve-peers-from-workspace-root=false aren't ready yet.
Looking at which packages you had to add to {configs,docs,tests}/**/package.json, it seemed to me like pnpm didn't fully understand how the lint packages and Ember projects work, but applied its rules blindly. (Maybe turning these flags off will work better in v9?)
To minimize change, let's just add @babel/core to ember-intl's dependencies, which follows the upgrade guide and aligns with Ember's blueprints. This would also help me cut a patch release for ember-intl@v6. Is this okay?
|
@ijlee2 yes thats good |
ijlee2
added a commit
that referenced
this pull request
May 14, 2024
…1880) --------- Co-authored-by: ijlee2 <ijlee2@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard of packages managers are, that they are installing automatically missing dependencies.
To avoid problems in consumer apps, we should disable auto installing dependencies by using a stricter dependency managment.
This is possible by adding
.npmrcwith some options.Atm in
.npmrcthere wasstrict-peer-dependencies=false... this is the default value in pnpm 8 + 9 so we can remove it. https://pnpm.io/8.x/npmrc