Refactored code in lib #1882
Merged
Refactored code in lib #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te-lint and ember-i18n)
ijlee2
commented
May 14, 2024
| do { | ||
| if (isEngine(current)) { | ||
| return current; | ||
| const isEngine = addon.pkg?.keywords.includes('ember-engine'); |
There was a problem hiding this comment.
TODO
Needs an additional ?..
const isEngine = addon.pkg?.keywords?.includes('ember-engine');
ijlee2
added a commit
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
To migrate
ember-intlto v2 format, I need to understand the files inlibfolder better and makeaddon/index.jsas ordinary as possible.I noticed that a couple of lines (e.g.
isLocalizationFramework,isAbsolutePath()) don't apply anymore and should have been long removed. In addition to improving code readability, the pull request will reduce the package size by ~2kB.