Fix crash in no-unsupported-role-attributes rule (#2917)

ember-template-lint · Jun 17, 2023 · 71bf8bb · 71bf8bb
1 parent 516d531
commit 71bf8bb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/lib/rules/no-unsupported-role-attributes.js b/lib/rules/no-unsupported-role-attributes.js
@@ -13,7 +13,7 @@ function createUnsupportedAttributeErrorMessage(attr, role, element) {
 function getImplicitRole(element, typeAttribute) {
   if (element === 'input') {
     for (let key of elementRoles.keys()) {
-      if (key.name === element) {
+      if (key.name === element && key.attributes) {
         let attributes = key.attributes;
         for (let attribute of attributes) {
           if (attribute.name === 'type' && attribute.value === typeAttribute) {

diff --git a/test/unit/rules/no-unsupported-role-attributes-test.js b/test/unit/rules/no-unsupported-role-attributes-test.js
@@ -24,6 +24,7 @@ generateRuleTests({
     '{{other-component role=this.role aria-bogus="true"}}',
     '<ItemCheckbox @model={{@model}} @checkable={{@checkable}} />',
     '<some-custom-element />',
+    '<input type="password">',
   ],
 
   bad: [