Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Bryan Mishkin <698306+bmish@users.noreply.github.com>
  • Loading branch information
2 people authored and NullVoxPopuli committed Jun 26, 2023
1 parent d01b765 commit 8f568a4
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions docs/rule/no-at-ember-render-modifiers.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

`@ember/render-modifiers` were meant as a transitional tool from the pre-Octane era, and not long-term usage.

More information about this can be found on the [`@ember/render-modifiers` README](https://github.com/emberjs/ember-render-modifiers#when-to-use-these-modifiers-and-when-not-to-use-them)
More information about this can be found on the [`@ember/render-modifiers` README](https://github.com/emberjs/ember-render-modifiers#when-to-use-these-modifiers-and-when-not-to-use-them).

## Examples

Expand All @@ -22,7 +22,7 @@ This rule **forbids** the following:

## Migration

The migration path typically depends on what the render-modifier was used for, but if you need a customm modifier, the [`ember-modifier` README](https://github.com/ember-modifier/ember-modifier) covers everything you need to know for making custom modifiers.
The migration path typically depends on what the render-modifier was used for, but if you need a custom modifier, the [`ember-modifier` README](https://github.com/ember-modifier/ember-modifier) covers everything you need to know for making custom modifiers.

For example, if render modifiers were used for setup/teardown, the migration to `ember-modifier` could be the following:

Expand All @@ -46,5 +46,5 @@ export default class MyComponent extends Component {

## References

- [`@ember/render-modifiers`](https://github.com/emberjs/ember-render-modifiers)
- [`@ember/render-modifiers`](https://github.com/emberjs/ember-render-modifiers) (deprecated)
- [`ember-modifier`](https://github.com/ember-modifier/ember-modifier)

0 comments on commit 8f568a4

Please sign in to comment.