-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Todo feature] Missing newline when generating remove
lines in .lint-todo
#2482
Comments
also running into this bug |
I saw this behavior after I fixed some "no-implicit-this" errors in a .hbs file. |
this doesn't just happen with "remove", I have also seen "add" not on a new line as well. |
This could have been fixed already, but should be fixed for sure in I've posted a PR for ember-template-lint to update to it |
The issue was that certain commands were not applying a newline to the end of the file, depending on what version you were using. Then, after that, if you did an append operation (like update-todo) it would be joined to the line prior since there was no newline. 13.1.1 should have fixed all the remaining commands to apply a newline after their output - but if you have a |
Should be fixed by #2955. |
After fixing some linting errors that were previously added to the
.lint-todo
file I rannpm run lint:hbs
to check if I didn't create any new issues. To my confusion a totally unrelated linting error was shown.Upon inspection of the
.lint-todo
file, I noticed that newremove
prefixed lines were added but the first one didn't start on a new line and instead started right at the end of the previousadd
line which made the error appear again in the linting output:Manually moving it to a new line makes it work as expected again.
The text was updated successfully, but these errors were encountered: