Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @lint-todo/utils to 13.1.1 #2955

Merged
merged 1 commit into from Aug 12, 2023

Conversation

Techn1x
Copy link
Contributor

@Techn1x Techn1x commented Aug 12, 2023

I recently contributed to @lint-todo/utils package and would love to see that fix given to everyone.

This fix ensures --compact-todo ends the file with a newline (previously it was always stripping the final newline in the file). This avoids other knock on issues like;

  • doubled operation lines after an update-todo or other "append" task, which then cause;
    • lint errors to reappear
    • more merge conflicts
    • errornous lines in the file that are never cleaned up

Above all I think it would be worthwhile just to ensure that reported issues in ETL are as reported and not subtly caused by the above.
Fixes #2482

@Techn1x
Copy link
Contributor Author

Techn1x commented Aug 12, 2023

Note that while it fixes the commands - users with .lint-todo files generated by a prior version of @lint-todo/utils where they don't have the newline at the end will still have their next command append and cause a doubled-operation line. But hopefully that just goes away over time.

@Techn1x
Copy link
Contributor Author

Techn1x commented Aug 12, 2023

Not sure what that failing windows test is, but I assume it's flaky and not something to do with this PR.

@bmish bmish requested a review from scalvert August 12, 2023 08:14
@bmish
Copy link
Member

bmish commented Aug 12, 2023

Since this is just a minor version upgrade (https://github.com/lint-todo/utils/releases/tag/v13.1.1), and we use caret version ranges anyway, I'll go ahead and merge this, thanks. Note that we will get upgrades like this from Dependabot too.

Our Node 14 tests are a bit flaky.

@bmish bmish merged commit 25d5ba7 into ember-template-lint:master Aug 12, 2023
11 checks passed
@bmish bmish changed the title chore: lint todo utils to 13.1.1, fixes compact todo issues Update @lint-todo/utils to 3.1.1 Aug 12, 2023
@bmish bmish added the bug label Aug 12, 2023
@peternowee
Copy link

@bmish Title should be 13.1.1.

@Techn1x Techn1x changed the title Update @lint-todo/utils to 3.1.1 Update @lint-todo/utils to 13.1.1 Aug 22, 2023
@Techn1x
Copy link
Contributor Author

Techn1x commented Aug 22, 2023

thx fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Todo feature] Missing newline when generating remove lines in .lint-todo
3 participants