Cannot read property name of undefined

[prabakaranfresh]

aria-query released a new package 5.2.1 which is throwing an error for undefined in elementsRoleMap get method. All the component invocations which are undefined elementRoles are throwing as errors.

https://github.com/A11yance/aria-query/releases/tag/v5.2.1

Since the package.json didn't have a lock, the following error is occurring in template files which has a component invocation

-- error: Cannot read property 'name' of undefined undefined

[boris-petrov]

I already opened an issue in aria-query.

[villander]

I got a fix with pnpm overrides:

"pnpm": {
    "overrides": {
      "aria-query": "5.1.3"
    },
}

[boris-petrov]

So this is a bug in ember-template-lint - check this comment.

[kategengler]

Link to the offending line

ember-template-lint/lib/rules/no-unsupported-role-attributes.js

Line 26 in aec8962

let implicitRoles = elementRoles.get(elementRoles.keys().find((key) => key.name === element));

This is breaking ember-cli's CI as well as the super-rentals-tutorial build.

[bmish]

Looks like it should be an easy fix. Can we get a failing code sample?

[kategengler]

Conveniently, the tests for the rule are failing with floating dependencies in this repo's own CI https://github.com/ember-template-lint/ember-template-lint/actions/runs/5262654063/jobs/9512048400

[bmish]

Let's see if this fixes it: #2914

[ef4]

Ugh, aria-query has now released a 5.3 that appears to undo these changes in 5.2.1. Their changelog literally says not to try using 5.2.

This breaks us again.

[ef4]

Nevermind, false alarm! I accidentally was looking at a version of ember-template-lint before this PR.