Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more options to quotes rule #617

Closed
kellyselden opened this issue Jan 19, 2019 · 4 comments · Fixed by #2754
Closed

more options to quotes rule #617

kellyselden opened this issue Jan 19, 2019 · 4 comments · Fixed by #2754

Comments

@kellyselden
Copy link
Member

I implemented the quotes rule the quickest and to satisfy the style I was using. It is now clear that there should be at least one more option for when you enter hbs syntax.

Some people prefer

<foo bar="asdf" baz={{concat 'asdf' 'asdf'}} />

This is not possible with the current rule, where it is all or nothing double qoutes.

I'm not sure the api, but maybe something like

'quotes': {
  outsideCurlies: 'double',
  insideCurlies: 'single'
}
@pieter-v
Copy link

This becomes more important, since prettier formats templates this way.

@robclancy
Copy link
Contributor

robclancy commented Dec 22, 2022

Been open since 2019... how do we do this? When I enabled this rule I kinda expected it to just ignore the HTML quotes.

Also could the options be "htmlQuotes" and "hdsQuotes" (or just hbs and html)?

@robclancy
Copy link
Contributor

I think it's done #2754

@bmish
Copy link
Member

bmish commented May 24, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants