Add options for different html / hbs quote styles in quotes rule
#2754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmish
reviewed
Dec 22, 2022
bmish
reviewed
Dec 22, 2022
bmish
changed the title
html / hbs quote styles in quotes rule
|
What's the status of this? |
I noticed that this hadn't been picked up in a while, so I just made some changes to resolve the comments and push it across the finish line. I think it's good to go now - lmk if you have any additional comments. @bmish |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I did this right?
Fixes #617
Personally I think the default config should be as described in the issue above with double only used for HTML attributes. Also the config forces the need to specify both
hbsandhtmlbut it could also just default todoublefor whichever one of those is missing. So for example you could just do{ hbs: 'single' }to get the same functionality, essentially still usingdoubleas a default.Some code/messages etc in here could probably use better words. Maybe moustache/curlies instead of handlebars for example. And HTML Attributes instead of just HTML. I'm too tired to deal with naming things.
I think it might need more tests too?