Convert path to URL before import of config/plugin for Windows support #2339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmish
reviewed
Jan 13, 2022
|
Maybe you can add an acceptance test that passes a windows-style path to the CLI? There's a config path CLI option. |
bmish
reviewed
Jan 13, 2022
bmish
changed the title
bmish
reviewed
Feb 9, 2022
|
From what I remember, we had trouble reproducing the issue in the test and so I wasn't confident that the test actually verified it was fixed. |
|
Is there any update on this PR? If not is there any decent workaround? |
|
If someone can confirm that this PR fixes the issue, we might be able to move forward with it. |
|
@bmish I just pulled this branch down for ember-template-lint and tested. This absolutely fixes the issue. |
lifeart
force-pushed
the
fix-windows-config-loading
branch
from
33b7e7f
to
9073166
Compare
lifeart
force-pushed
the
fix-windows-config-loading
branch
from
1f19911
to
03e4b93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2336
I'm not sure how to test it, because chain for this function is quite long, should we create unit test for 'requirePlugin' function itself?