Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add &times to no-bare-strings default allow list #2422

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jbottigliero
Copy link

@jbottigliero jbottigliero commented Mar 16, 2022

Not sure if this exclusion is intentional or not, but it seems to be in line with other HTML entities in the allow list...

@bmish
Copy link
Member

bmish commented Mar 16, 2022

FYI there was some discussion about this in #1131.

@bmish bmish added the bug label Mar 16, 2022
@bmish bmish changed the title chore: × added to the no-bare-strings default allow list Add &times to no-bare-strings default allow list Mar 16, 2022
@jbottigliero
Copy link
Author

Thanks for the heads up @bmish; I've opened #2423, which seems closer to that desired functionality... for my use case I'll likely revert to an allowlist, but it seems like others might find the allowHTMLCharacters configuration useful? Happy to close this out and continue the conversation in the new PR – or close both out! 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants