Extract hasParentTag utility function
#2434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoaoDsv
changed the title
|
This looks fine, is this still a draft? |
JoaoDsv
changed the title
@bmish It's indeed not in draft anymore, I just wanted your opinion on it, as you was the requestor of this extraction. Feel free to approve it if it looks good to you, so we can unblock the "no-action-on-submit-button" MR 🙏 |
JoaoDsv
force-pushed
the
extract-parent-node
branch
from
a33ddd9
to
2b92cf4
Compare
bmish
changed the title
hasParentTag utility function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
hasFormParentfunction only exists in thelib/rules/require-button-type.jsrule file.We want to be able to reuse it in other rule, so we are extracting it in a more generic version.
FYI it will soon be used to complete this rule.