-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up moduleId
, add ability to specify ignore
via file path with extension
#2515
base: master
Are you sure you want to change the base?
Clean up moduleId
, add ability to specify ignore
via file path with extension
#2515
Conversation
This is out of scope for this PR, but should we update this example ember-template-lint/docs/ignore.md Lines 16 to 21 in ba97a87
to no longer duplicate ignores and remove ember-template-lint/docs/ignore.md Lines 25 to 33 in ba97a87
now that |
Also ember-template-lint/docs/ignore.md Line 35 in ba97a87
should probably be removed at this point, regardless. |
@jamescdavis very sorry about the delay on this. A few questions:
|
As described in #2128, when
ignore
is configured,moduleId
is still required when calling the node API'sverify()
despite the docs making no mention of this. This remedies that by cleaning up usage ofmoduleId
internally as proposed in #2128.There is at least one user of the node API that this is affecting: mansona/lint-to-the-future-ember-template#12
The one place I've left any reference to
moduleId
is withinlib/-private/module-status-cache
because configuration ofignore
for specific files (non-glob) currently requires specification as a module instead of a file path with extension, e.g.I have, though, added the ability to also specify specific files via path with extension, e.g.
and updated the docs to use this instead of by module.
This was motivated in part with wanting to have consistency with
overrides
(see #2513).We may want to deprecate specifying by module and remove in next major version.