Add failing tests for missing component structures in no-this-in-template-only-components
#2572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds two simple cases that should be valid component structures: - nested structure from --component-structure=nested - legacy pod structure from --pod
This adds logic to look for component class files in the expected location for nested and pod component structures, generated respectively by the `--component-structure=nested` and `--pod` CLI flags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two failing test cases that should be allowed as valid component structures for the
no-this-in-template-only-componentsrule:--component-structure=nested--pod(is this still valid?)This is related to #2321 and #2335.
Since this rule looks for external files I'm unsure how to proceed from here. For example, I've set the
meta.filePathto mimic different component structure patterns but how can I setup the appropriate component class files to properly test the unique scenarios for this rule?I've also added some initial logic to differentiate between the flat, nested, and pod component structures, but again, I'm unsure how to test this properly since it relies on the existence of external files.