Fix incorrect violation with embedded templates in no-trailing-spaces rule
#2833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinborst95
force-pushed
the
test/no-trailing-spaces-embedded
branch
from
36f43d2
to
1c84835
Compare
robinborst95
changed the title
no-trailing-spaces in embedded templatesno-trailing-spaces in embedded templates
bmish
changed the title
no-trailing-spaces in embedded templatesno-trailing-spaces rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2832. At first I thought
templateInfo.contents=>templateInfo.contents.trimEnd()inextract-templateswould be the solution (it does fix this added test), but it made other tests fail for good reasons it seemed. So, after fixing another rule, I cherry-picked thecolumnOffsetchanges from #2838, because this made it quite trivial to fix! I'm curious to hear anyone's thoughts on this (and the other PR) :)