Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid crash with dynamic aria-label in no-invalid-link-text rule #2843

Merged
merged 2 commits into from Mar 15, 2023
Merged

Avoid crash with dynamic aria-label in no-invalid-link-text rule #2843

merged 2 commits into from Mar 15, 2023

Conversation

StephanH90
Copy link
Contributor

@StephanH90 StephanH90 commented Mar 14, 2023 •
edited by bmish

Since MustacheStatements can return a valid aria string but don't respond to the regular string checks, we need to exit the rule early.

Fixes #2798

@bmish bmish changed the title Fix: allow mustache in link aria label Avoid crash with dynamic aria-label in no-invalid-link-text rule Mar 15, 2023
bmish
bmish approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@bmish bmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I've updated the PR to use the Fixes #xxx syntax to correctly link to the issue.

@bmish bmish added the bug label Mar 15, 2023
@bmish bmish merged commit 02462a2 into ember-template-lint:master Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmish bmish bmish approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no-invalid-link-text error with handlebars aria-label
2 participants
@StephanH90 @bmish