Disable embedded templates handling for eol-last rule
#2846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinborst95
changed the title
eol-last rule
bmish
reviewed
Mar 15, 2023
bmish
reviewed
Mar 15, 2023
robinborst95
force-pushed
the
fix/skip-eol-last-embedded
branch
from
a7d1f77
to
66b876e
Compare
bmish
reviewed
Mar 15, 2023
| @@ -5,6 +5,10 @@ import Rule from './_base.js'; | |||
|
|
|||
| export default class EolLast extends Rule { | |||
| parseConfig(config) { | |||
| if (!this.isStrictMode) { | |||
There was a problem hiding this comment.
Let's also add a note to the rule doc that this rule doesn't apply to embedded templates?
There was a problem hiding this comment.
I've adapted the rule doc as well! I figured the rule doc doesn't need an explanation, as it already said files specifically, which I made even more explicit by saying template files instead.
robinborst95
force-pushed
the
fix/skip-eol-last-embedded
branch
from
66b876e
to
cc0929e
Compare
bmish
changed the title
eol-last ruleeol-last rule (#2846
bmish
changed the title
eol-last rule (#2846eol-last rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our test suite this is the last remaining (enabled) rule that provides incorrect results in embedded templates. Enforcing a newline at the end of an embedded template doesn't make much sense to me, so disabling the rule seems the easiest solution. You could argue to set the config to
"never"instead of disabling completely, but that requires more changes and in the end it's not what this rule is meant for (which is having a newline or not at the end of a file, rather than at the end of a template).