Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new rule simple-modifiers #2887

Merged

Conversation

rmonzon
Copy link
Contributor

@rmonzon rmonzon commented May 18, 2023

Fixes #2863.

Modifiers should have the string as the first param to make things less convoluted and prevent issues with other rules.

Not good:

<div {{(modifier (unless this.hasBeenClicked "track-interaction") "click" customizeData=this.customizeClickData)}}>
  ...
</div>

Good:

<div {{(unless this.hasBeenClicked (modifier "track-interaction" "click" customizeData=this.customizeClickData))}}>
  ...
</div>

@rmonzon rmonzon marked this pull request as ready for review May 18, 2023 01:32
Co-authored-by: Chris Ng <chrisrng@users.noreply.github.com>
@lin-ll
Copy link
Collaborator

lin-ll commented May 22, 2023

I think the checks are still mad about the alphabetical order of the rules in the README. Did you use this command to update it? npm run update:readme

docs/rule/simple-modifiers.md Show resolved Hide resolved
docs/rule/simple-modifiers.md Outdated Show resolved Hide resolved
Co-authored-by: Lucy Lin <lucy.ly.lin@gmail.com>
Copy link
Member

@bmish bmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New rule: simple-modifier
4 participants