Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix location reporting in block-indentation rule #2907

Merged
merged 2 commits into from Jun 7, 2023

Conversation

judithhinlung
Copy link
Collaborator

Background

This PR fixes #2906, a bug in the block-indentation rule in which the same value is reported for start and end line locations.

  {{#each cats as |dog|}}
       {{/each}}

**Before**:
             {
              "column": 8,
               "endColumn": 8,
               "endLine": 2,
               "filePath": "layout.hbs",
               "isFixable": true,
              "line": 2,
...

**After**:
                "column": 0,
               "endColumn": 8,
               "endLine": 2,
               "filePath": "layout.hbs",
               "isFixable": true,
                "line": 1,
...

### Testing
Test Suites: 148 passed, 148 total
Tests:       5 skipped, 8517 passed, 8522 total
Snapshots:   1106 passed, 1106 total
Time:        139.666 s
Ran all test suites.
✨  Done in 174.15s.

@lin-ll lin-ll added the bug label Jun 6, 2023
@lin-ll lin-ll changed the title Fixes block-indentation location reporting Fix location reporting in block-indentation rule Jun 6, 2023
@judithhinlung judithhinlung marked this pull request as ready for review June 6, 2023 23:55
@lin-ll lin-ll merged commit 260c016 into ember-template-lint:master Jun 7, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block-indentation Reports Same Value for Start and End Location
2 participants