Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update incorrect tests #2915

Merged
merged 2 commits into from
Jun 16, 2023
Merged

Update incorrect tests #2915

merged 2 commits into from
Jun 16, 2023

Commits on Jun 14, 2023

  1. fix: crash in no-unsupported-role-attributes due to aria-query change

    @bmish
    bmish committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    7b4e9d8 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. fixing wrong tests 

    I'm pretty sure these tests were incorrect and it was just hidden by another bug.

The checkbox role *does* support aria-invalid. So I changed that one to button role, which does not.

Also, the menuitem element (not to be confused with the menuitem role) does not appear at all in the set of elementRoles from aria-query. So I changed that test to use `<a role="menuitem">` instead. The menuitem element is [deprecated and non-standard](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/menuitem).
    @ef4
    ef4 committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    9563bb4 View commit details
    Browse the repository at this point in the history