Support auto-lookup of .mjs and .cjs config files
#2970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertdeblock
force-pushed
the
support-auto-lookup-of-mjs-and-cjs-config-files
branch
2 times, most recently
from
7ecfb40
to
8ebf46c
Compare
|
@bmish If you have some time, would you mind looking at this PR? |
bmish
reviewed
Sep 12, 2023
|
This looks reasonable pending my one comment. |
bertdeblock
force-pushed
the
support-auto-lookup-of-mjs-and-cjs-config-files
branch
from
8ebf46c
to
ffc8576
Compare
bertdeblock
deleted the
support-auto-lookup-of-mjs-and-cjs-config-files
branch
bmish
changed the title
.mjs and .cjs config files.mjs and .cjs config files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ember-template-lintis written in ESM, which means plugins must be written in ESM as well.If you want to
importa plugin in yourember-template-lintconfig file, your project must be in ESM or yourember-template-lintconfig file must be an.mjsfile, but it seemsember-template-lintdoesn't auto lookup.template-lintrc.mjsconfig files. You can do--config-path=.template-lintrc.mjs, but that's a little verbose if you have multipleember-template-lintinvocations.