Remove template-imports, add content-tag, drop support for linting js, ts, templates made with ember-cli-htmlbars #3021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
changed the title
NullVoxPopuli
changed the title
|
I assume you'll want to get this into v6? |
|
aye, will be important as template-tag are now in the guides: https://guides.emberjs.com/release/components/template-tag-format/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change, all stemming from swapping out the template extraction tool.
Removing ember-template-imports, and adding content-tag means:
(this also has a perf benefit, as there will be more js/ts that no doesn't need to be checked)
Because I don't want to math too hard, I'm going to declare this blocked on: embroider-build/content-tag#70