add vars to scope manager declaredVariables #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So, they validate if the parent is a function... |
|
I think typescript also has their own copy of no-unused-var -- wouldn't be unheard of, I guess |
This makes eslint sourceCode getDeclaredVariables work which is required for some rules to work
patricklx
force-pushed
the
add-vars-to-scope-manager-declaredVariables
branch
from
7e55d06
to
094967f
Compare
|
this does not fix the issue we had, but i think its still good to have it |
| @@ -508,12 +508,17 @@ module.exports.convertAst = function convertAst(result, preprocessedResult, visi | |||
| const scope = result.isTypescript | |||
| ? new TypescriptScope.BlockScope(result.scopeManager, upperScope, node) | |||
| : new Scope(result.scopeManager, 'block', upperScope, node); | |||
| const declaredVariables = | |||
NullVoxPopuli
approved these changes
Apr 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes eslint sourceCode getDeclaredVariables work which is required for some rules to work.