fix: filterBy should compare values #8171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
reviewed
Sep 8, 2022
| return this.filter((value) => { | ||
| return Boolean(get(value, key)); | ||
| return this.filter((record) => { | ||
| return Boolean(get(record, key)); |
There was a problem hiding this comment.
🤦 you may want to check the other implementations to make sure I didn't make a similar mistake with them
There was a problem hiding this comment.
😆 copy paste so useful, so easy to mess up. I eyeballed the rest and they looked good, decided not to write a bunch of soon to be deprecated tests though seemed like overkill.
runspired
approved these changes
Sep 8, 2022
runspired
reviewed
Sep 8, 2022
| @@ -97,6 +97,46 @@ module('unit/record-arrays/record-array - DS.RecordArray', function (hooks) { | |||
| assert.strictEqual(recordArray[3], undefined); | |||
| }); | |||
|
|
|||
| test('#filterBy', async function (assert) { | |||
There was a problem hiding this comment.
you'll want to use deprecatedTest vs assert.expectDeprecation both so we know to clean it up later and because it will then get skipped when deprecations are removed and we run the tests.
There was a problem hiding this comment.
this is a perfectly fine place for this test btw
There was a problem hiding this comment.
🆒 thanks. Fixed.
FilterBy can be called with and without a second argument, when the second argument is used the filter should compare that value to the value in the record.
This was referenced Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FilterBy can be called with and without a second argument, when the second argument is used the filter should compare that value to the value in the record.
I slapped the test for this in a sort of random spot because I wasn't sure where it goes.
Type of PR
What kind of change is this?