Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use array notation instead of at for accessing values (#8184) #8185

Merged
merged 1 commit into from Sep 16, 2022
Merged

Use array notation instead of at for accessing values (#8184) #8185

merged 1 commit into from Sep 16, 2022

Conversation

jrjohnson
Copy link
Sponsor Contributor

Backport #8184 to release:

Array.at isn't supported in Safari until 15.4, using brackets isn't as pretty, but enjoys universal support.

@jrjohnson
Use array notation instead of at for accessing values (#8184)
ea0ea69 
Array.at isn't supported in Safari until 15.4, using brackets isn't as
pretty, but enjoys universal support.
@jrjohnson jrjohnson added 🏷️ bug This PR primarily fixes a reported issue backport-release PR targets the current release branch labels Sep 16, 2022
@jrjohnson jrjohnson marked this pull request as ready for review September 16, 2022 02:58
@runspired runspired merged commit fe3cb6a into emberjs:release Sep 16, 2022
@jrjohnson jrjohnson deleted the 8184-backport-release branch September 17, 2022 00:18
@runspired
Copy link
Contributor

@jrjohnson we probably should do this for objectAt and objectsAt as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runspired runspired Awaiting requested review from runspired

Assignees
No one assigned
Labels
backport-release PR targets the current release branch 🏷️ bug This PR primarily fixes a reported issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jrjohnson @runspired