Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use array notation instead of at for accessing object at values #8189

Merged
merged 1 commit into from Sep 22, 2022
Merged

Use array notation instead of at for accessing object at values #8189

merged 1 commit into from Sep 22, 2022

Conversation

jrjohnson
Copy link
Sponsor Contributor

Description

Array.at isn't supported in Safari until 15.4, using brackets isn't as pretty, but enjoys universal support.

Type of PR

  • user-facing bugfix

@jrjohnson jrjohnson added 🎯 release PR should be backported to release 🎯 canary PR is targeting canary (default) 🏷️ bug This PR primarily fixes a reported issue labels Sep 21, 2022
@jrjohnson jrjohnson marked this pull request as ready for review September 21, 2022 22:13
@runspired runspired merged commit b87b401 into emberjs:master Sep 22, 2022
@jrjohnson jrjohnson removed the 🎯 release PR should be backported to release label Sep 22, 2022
@jrjohnson jrjohnson deleted the object-at-access branch September 22, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 canary PR is targeting canary (default) 🏷️ bug This PR primarily fixes a reported issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants