fix: fix MandatorySetter error for Proxied PromiseProxy, silence ember-concurrency deprecations #8206

runspired · 2022-10-13T22:17:41Z

No description provided.

github-actions · 2022-10-13T22:22:49Z

Asset Size Report for 027da7c

Modern Builds

☑️ EmberData has not changed in size

If any packages had changed sizes they would be listed here.

Changeset

Full Asset Analysis (Modern)


Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '165.21 KB' │
│ compressed │ '35.28 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '44.75 KB' │
│  compressed  │ '9.56 KB'  │
│ % Of Library │   '27.1'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 44.27 KB  | 9.46 KB    | 98.9          | 26.8
	@ember-data/model/index                           | 486.00 B  | 103.79 B   | 1.1           | 0.3

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '42.96 KB' │
│  compressed  │ '9.17 KB'  │
│ % Of Library │   '26.0'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 41.96 KB  | 8.96 KB    | 97.7          | 25.4
	@ember-data/store/index                           | 1022.00 B | 218.25 B   | 2.3           | 0.6

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '23.36 KB' │
│  compressed  │ '4.99 KB'  │
│ % Of Library │   '14.1'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 23.36 KB  | 4.99 KB    | 100.0         | 14.1

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '20.42 KB' │
│  compressed  │ '4.36 KB'  │
│ % Of Library │   '12.4'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.36 KB   | 1.57 KB    | 36.0          | 4.5
	@ember-data/serializer/-private                   | 5.60 KB   | 1.20 KB    | 27.4          | 3.4
	@ember-data/serializer/json-api                   | 3.79 KB   | 828.82 B   | 18.6          | 2.3
	@ember-data/serializer/rest                       | 2.87 KB   | 626.58 B   | 14.0          | 1.7
	@ember-data/serializer/index                      | 611.00 B  | 130.48 B   | 2.9           | 0.4
	@ember-data/serializer/transform                  | 215.00 B  | 45.91 B    | 1.0           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '15.93 KB' │
│  compressed  │ '3.40 KB'  │
│ % Of Library │   '9.6'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 7.88 KB   | 1.68 KB    | 49.5          | 4.8
	@ember-data/adapter/-private                      | 3.79 KB   | 827.75 B   | 23.8          | 2.3
	@ember-data/adapter/error                         | 1.82 KB   | 398.50 B   | 11.4          | 1.1
	@ember-data/adapter/index                         | 1.41 KB   | 308.80 B   | 8.9           | 0.9
	@ember-data/adapter/json-api                      | 1.03 KB   | 226.15 B   | 6.5           | 0.6

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '8.32 KB' │
│  compressed  │ '1.78 KB' │
│ % Of Library │   '5.0'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 1.98 KB   | 433.95 B   | 23.8          | 1.2
	ember-data/-private                               | 1.53 KB   | 335.50 B   | 18.4          | 0.9
	ember-data/adapters/errors                        | 1.19 KB   | 259.90 B   | 14.3          | 0.7
	ember-data/setup-container                        | 368.00 B  | 78.58 B    | 4.3           | 0.2
	ember-data/relationships                          | 318.00 B  | 67.91 B    | 3.7           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 58.51 B    | 3.2           | 0.2
	ember-data/serializers/json-api                   | 251.00 B  | 53.60 B    | 2.9           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 52.32 B    | 2.9           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 51.89 B    | 2.9           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 51.89 B    | 2.9           | 0.1
	ember-data/transform                              | 241.00 B  | 51.46 B    | 2.8           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 50.61 B    | 2.8           | 0.1
	ember-data/serializer                             | 232.00 B  | 49.54 B    | 2.7           | 0.1
	ember-data/adapter                                | 226.00 B  | 48.26 B    | 2.7           | 0.1
	ember-data/model                                  | 222.00 B  | 47.41 B    | 2.6           | 0.1
	ember-data/store                                  | 222.00 B  | 47.41 B    | 2.6           | 0.1
	ember-data/attr                                   | 218.00 B  | 46.55 B    | 2.6           | 0.1
	ember-data/version                                | 161.00 B  | 34.38 B    | 1.9           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.71 KB' │
│  compressed  │ '1.43 KB' │
│ % Of Library │   '4.1'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 3.00 KB   | 656.48 B   | 44.8          | 1.8
	ember-inflector/lib/system/inflections            | 1.59 KB   | 347.46 B   | 23.7          | 1.0
	ember-inflector/lib/system                        | 471.00 B  | 100.58 B   | 6.9           | 0.3
	ember-inflector/index                             | 379.00 B  | 80.93 B    | 5.5           | 0.2
	ember-inflector/lib/helpers/pluralize             | 369.00 B  | 78.80 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 332.00 B  | 70.90 B    | 4.8           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 67.91 B    | 4.6           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 63.21 B    | 4.3           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.77 KB'  │
│  compressed  │ '605.01 B' │
│ % Of Library │   '1.7'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.27 KB   | 497.16 B   | 82.2          | 1.4
	@ember-data/debug/setup                           | 505.00 B  | 107.84 B   | 17.8          | 0.3

Modern Builds (No Rollup)

✅ EmberData shrank by -879.0 B (-127.0 B compressed)

If any packages had changed sizes they would be listed here.

Changeset


EmberData 203.59 KB -879.0 B (38.9 KB -127.0 B compressed)
    @ember-data/store 63.44 KB -601.0 B (12.12 KB -86.83 B compressed)
        @ember-data/store/-private/proxies/promise-proxies 1.09 KB -601.0 B (213.39 B -86.83 B compressed)
    @ember-data/model 50.83 KB -278.0 B (9.71 KB -40.17 B compressed)
        @ember-data/model/-private/deprecated-promise-proxy 403.0 B -278.0 B (76.99 B -40.17 B compressed)

Full Asset Analysis (Modern)


Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '203.59 KB' │
│ compressed │ '38.90 KB'  │
│  packages  │      8      │
│  modules   │     126     │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '63.44 KB' │
│  compressed  │ '12.12 KB' │
│ % Of Library │   '31.2'   │
└──────────────┴────────────┘
	Module                                                                        | Bytes     | Compressed | % of Package  | % Of Library
	---------------------------------------------------------------------------------------------------------------------------------
	@ember-data/store/-private/store-service                                      | 10.59 KB  | 2.02 KB    | 16.7          | 5.2
	@ember-data/store/-private/managers/record-data-manager                       | 7.90 KB   | 1.51 KB    | 12.5          | 3.9
	@ember-data/store/-private/caches/instance-cache                              | 5.90 KB   | 1.13 KB    | 9.3           | 2.9
	@ember-data/store/-private/network/fetch-manager                              | 4.89 KB   | 955.81 B   | 7.7           | 2.4
	@ember-data/store/-private/record-arrays/identifier-array                     | 4.27 KB   | 835.06 B   | 6.7           | 2.1
	@ember-data/store/-private/caches/identifier-cache                            | 3.66 KB   | 716.42 B   | 5.8           | 1.8
	@ember-data/store/-private/network/snapshot                                   | 3.31 KB   | 647.65 B   | 5.2           | 1.6
	@ember-data/store/-private/managers/record-array-manager                      | 3.07 KB   | 601.22 B   | 4.8           | 1.5
	@ember-data/store/-private/index                                              | 2.74 KB   | 535.12 B   | 4.3           | 1.3
	@ember-data/store/-private/managers/record-data-store-wrapper                 | 1.62 KB   | 317.52 B   | 2.6           | 0.8
	@ember-data/store/-private/network/request-cache                              | 1.61 KB   | 314.08 B   | 2.5           | 0.8
	@ember-data/store/-private/legacy-model-support/shim-model-class              | 1.55 KB   | 302.42 B   | 2.4           | 0.8
	@ember-data/store/-private/network/finders                                    | 1.51 KB   | 296.12 B   | 2.4           | 0.7
	@ember-data/store/-private/legacy-model-support/schema-definition-service     | 1.37 KB   | 268.80 B   | 2.2           | 0.7
	@ember-data/store/-private/legacy-model-support/record-reference              | 1.34 KB   | 261.92 B   | 2.1           | 0.7
	@ember-data/store/-private/proxies/promise-proxies                            | 1.09 KB   | 213.39 B   | 1.7           | 0.5
	@ember-data/store/index                                                       | 1022.00 B | 195.25 B   | 1.6           | 0.5
	@ember-data/store/-private/utils/uuid-polyfill                                | 786.00 B  | 150.16 B   | 1.2           | 0.4
	@ember-data/store/-private/managers/record-notification-manager               | 753.00 B  | 143.85 B   | 1.2           | 0.4
	@ember-data/store/-private/network/snapshot-record-array                      | 691.00 B  | 132.01 B   | 1.1           | 0.3
	@ember-data/store/-private/utils/construct-resource                           | 688.00 B  | 131.44 B   | 1.1           | 0.3
	@ember-data/store/-private/utils/common                                       | 572.00 B  | 109.27 B   | 0.9           | 0.3
	@ember-data/store/-private/utils/coerce-id                                    | 473.00 B  | 90.36 B    | 0.7           | 0.2
	@ember-data/store/-private/proxies/promise-proxy-base                         | 403.00 B  | 76.99 B    | 0.6           | 0.2
	@ember-data/store/-private/caches/record-data-for                             | 325.00 B  | 62.09 B    | 0.5           | 0.2
	@ember-data/store/-private/utils/identifer-debug-consts                       | 304.00 B  | 58.07 B    | 0.5           | 0.1
	@ember-data/store/-private/utils/promise-record                               | 291.00 B  | 55.59 B    | 0.4           | 0.1
	@ember-data/store/-private/utils/serializer-response                          | 258.00 B  | 49.29 B    | 0.4           | 0.1
	@ember-data/store/-private/utils/normalize-model-name                         | 219.00 B  | 41.83 B    | 0.3           | 0.1
	@ember-data/store/-debug/index                                                | 207.00 B  | 39.54 B    | 0.3           | 0.1
	@ember-data/store/-private/utils/is-non-empty-string                          | 204.00 B  | 38.97 B    | 0.3           | 0.1

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '50.83 KB' │
│  compressed  │ '9.71 KB'  │
│ % Of Library │   '25.0'   │
└──────────────┴────────────┘
	Module                                                      | Bytes     | Compressed | % of Package  | % Of Library
	---------------------------------------------------------------------------------------------------------------
	@ember-data/model/-private/model                            | 11.25 KB  | 2.15 KB    | 22.1          | 5.5
	@ember-data/model/-private/legacy-relationships-support     | 7.94 KB   | 1.52 KB    | 15.6          | 3.9
	@ember-data/model/-private/record-state                     | 6.52 KB   | 1.25 KB    | 12.8          | 3.2
	@ember-data/model/-private/references/has-many              | 3.20 KB   | 626.25 B   | 6.3           | 1.6
	@ember-data/model/-private/references/belongs-to            | 2.81 KB   | 550.40 B   | 5.5           | 1.4
	@ember-data/model/-private/promise-many-array               | 2.70 KB   | 528.62 B   | 5.3           | 1.3
	@ember-data/model/-private/legacy-data-fetch                | 2.59 KB   | 505.89 B   | 5.1           | 1.3
	@ember-data/model/-private/many-array                       | 2.35 KB   | 459.27 B   | 4.6           | 1.2
	@ember-data/model/-private/errors                           | 2.31 KB   | 451.82 B   | 4.5           | 1.1
	@ember-data/model/-private/index                            | 1.48 KB   | 290.20 B   | 2.9           | 0.7
	@ember-data/model/-private/relationship-meta                | 991.00 B  | 189.32 B   | 1.9           | 0.5
	@ember-data/model/-private/notify-changes                   | 913.00 B  | 174.42 B   | 1.8           | 0.4
	@ember-data/model/-private/attr                             | 839.00 B  | 160.28 B   | 1.6           | 0.4
	@ember-data/model/-private/has-many                         | 817.00 B  | 156.08 B   | 1.6           | 0.4
	@ember-data/model/-private/belongs-to                       | 736.00 B  | 140.61 B   | 1.4           | 0.4
	@ember-data/model/-private/promise-belongs-to               | 615.00 B  | 117.49 B   | 1.2           | 0.3
	@ember-data/model/-private/util                             | 522.00 B  | 99.72 B    | 1.0           | 0.3
	@ember-data/model/index                                     | 486.00 B  | 92.84 B    | 0.9           | 0.2
	@ember-data/model/-private/diff-array                       | 445.00 B  | 85.01 B    | 0.9           | 0.2
	@ember-data/model/-private/model-for-mixin                  | 407.00 B  | 77.75 B    | 0.8           | 0.2
	@ember-data/model/-private/deprecated-promise-proxy         | 403.00 B  | 76.99 B    | 0.8           | 0.2
	@ember-data/model/-private/legacy-data-utils                | 395.00 B  | 75.46 B    | 0.8           | 0.2
	@ember-data/model/-private/promise-proxy-base               | 284.00 B  | 54.25 B    | 0.5           | 0.1

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '30.75 KB' │
│  compressed  │ '5.87 KB'  │
│ % Of Library │   '15.1'   │
└──────────────┴────────────┘
	Module                                                                            | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private/record-data                                      | 7.17 KB   | 1.37 KB    | 23.3          | 3.5
	@ember-data/record-data/-private/graph/graph                                      | 5.89 KB   | 1.12 KB    | 19.1          | 2.9
	@ember-data/record-data/-private/graph/operations/replace-related-records         | 3.63 KB   | 710.88 B   | 11.8          | 1.8
	@ember-data/record-data/-private/graph/-edge-definition                           | 3.12 KB   | 609.63 B   | 10.1          | 1.5
	@ember-data/record-data/-private/graph/-utils                                     | 2.10 KB   | 411.70 B   | 6.8           | 1.0
	@ember-data/record-data/-private/graph/operations/update-relationship             | 1.51 KB   | 295.55 B   | 4.9           | 0.7
	@ember-data/record-data/-private/graph/operations/merge-identifier                | 1.26 KB   | 246.25 B   | 4.1           | 0.6
	@ember-data/record-data/-private/graph/operations/replace-related-record          | 1.21 KB   | 236.70 B   | 3.9           | 0.6
	@ember-data/record-data/-private/graph/operations/add-to-related-records          | 829.00 B  | 158.37 B   | 2.6           | 0.4
	@ember-data/record-data/-private/graph/operations/remove-from-related-records     | 708.00 B  | 135.26 B   | 2.2           | 0.3
	@ember-data/record-data/-private/relationships/state/belongs-to                   | 707.00 B  | 135.07 B   | 2.2           | 0.3
	@ember-data/record-data/-private/relationships/state/has-many                     | 692.00 B  | 132.20 B   | 2.2           | 0.3
	@ember-data/record-data/-private/index                                            | 497.00 B  | 94.95 B    | 1.6           | 0.2
	@ember-data/record-data/-private/graph/index                                      | 482.00 B  | 92.08 B    | 1.5           | 0.2
	@ember-data/record-data/-private/coerce-id                                        | 379.00 B  | 72.40 B    | 1.2           | 0.2
	@ember-data/record-data/-private/graph/-state                                     | 293.00 B  | 55.97 B    | 0.9           | 0.1
	@ember-data/record-data/-private/normalize-link                                   | 238.00 B  | 45.46 B    | 0.8           | 0.1
	@ember-data/record-data/-private/graph/-operations                                | 150.00 B  | 28.65 B    | 0.5           | 0.1

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '22.43 KB' │
│  compressed  │ '4.29 KB'  │
│ % Of Library │   '11.0'   │
└──────────────┴────────────┘
	Module                                                     | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                                | 7.36 KB   | 1.41 KB    | 32.8          | 3.6
	@ember-data/serializer/-private/embedded-records-mixin     | 4.59 KB   | 898.68 B   | 20.5          | 2.3
	@ember-data/serializer/json-api                            | 3.79 KB   | 741.45 B   | 16.9          | 1.9
	@ember-data/serializer/rest                                | 2.87 KB   | 560.53 B   | 12.8          | 1.4
	@ember-data/serializer/-private/index                      | 1018.00 B | 194.48 B   | 4.4           | 0.5
	@ember-data/serializer/index                               | 611.00 B  | 116.72 B   | 2.7           | 0.3
	@ember-data/serializer/-private/transforms/date            | 530.00 B  | 101.25 B   | 2.3           | 0.3
	@ember-data/serializer/-private/transforms/boolean         | 504.00 B  | 96.28 B    | 2.2           | 0.2
	@ember-data/serializer/-private/transforms/number          | 439.00 B  | 83.86 B    | 1.9           | 0.2
	@ember-data/serializer/-private/transforms/string          | 371.00 B  | 70.87 B    | 1.6           | 0.2
	@ember-data/serializer/-private/transforms/transform       | 226.00 B  | 43.17 B    | 1.0           | 0.1
	@ember-data/serializer/transform                           | 215.00 B  | 41.07 B    | 0.9           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '18.04 KB' │
│  compressed  │ '3.45 KB'  │
│ % Of Library │   '8.9'    │
└──────────────┴────────────┘
	Module                                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                                      | 7.88 KB   | 1.51 KB    | 43.7          | 3.9
	@ember-data/adapter/-private/build-url-mixin                  | 1.92 KB   | 375.21 B   | 10.6          | 0.9
	@ember-data/adapter/error                                     | 1.82 KB   | 356.49 B   | 10.1          | 0.9
	@ember-data/adapter/index                                     | 1.41 KB   | 276.25 B   | 7.8           | 0.7
	@ember-data/adapter/json-api                                  | 1.03 KB   | 202.31 B   | 5.7           | 0.5
	@ember-data/adapter/-private/index                            | 1.03 KB   | 201.74 B   | 5.7           | 0.5
	@ember-data/adapter/-private/utils/serialize-query-params     | 769.00 B  | 146.91 B   | 4.2           | 0.4
	@ember-data/adapter/-private/utils/determine-body-promise     | 556.00 B  | 106.22 B   | 3.0           | 0.3
	@ember-data/adapter/-private/utils/parse-response-headers     | 488.00 B  | 93.23 B    | 2.6           | 0.2
	@ember-data/adapter/-private/utils/fetch                      | 450.00 B  | 85.97 B    | 2.4           | 0.2
	@ember-data/adapter/-private/utils/serialize-into-hash        | 382.00 B  | 72.98 B    | 2.1           | 0.2
	@ember-data/adapter/-private/utils/continue-on-reject         | 222.00 B  | 42.41 B    | 1.2           | 0.1
	@ember-data/adapter/-private/fastboot-interface               | 147.00 B  | 28.08 B    | 0.8           | 0.1

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '8.64 KB' │
│  compressed  │ '1.65 KB' │
│ % Of Library │   '4.2'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 1.98 KB   | 388.20 B   | 23.0          | 1.0
	ember-data/-private/index                         | 1.49 KB   | 291.72 B   | 17.3          | 0.7
	ember-data/adapters/errors                        | 1.19 KB   | 232.50 B   | 13.8          | 0.6
	ember-data/-private/core                          | 368.00 B  | 70.30 B    | 4.2           | 0.2
	ember-data/setup-container                        | 368.00 B  | 70.30 B    | 4.2           | 0.2
	ember-data/relationships                          | 318.00 B  | 60.75 B    | 3.6           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 52.34 B    | 3.1           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 47.95 B    | 2.8           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 46.80 B    | 2.8           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 46.42 B    | 2.7           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 46.42 B    | 2.7           | 0.1
	ember-data/transform                              | 241.00 B  | 46.04 B    | 2.7           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 45.27 B    | 2.7           | 0.1
	ember-data/serializer                             | 232.00 B  | 44.32 B    | 2.6           | 0.1
	ember-data/adapter                                | 226.00 B  | 43.17 B    | 2.6           | 0.1
	ember-data/model                                  | 222.00 B  | 42.41 B    | 2.5           | 0.1
	ember-data/store                                  | 222.00 B  | 42.41 B    | 2.5           | 0.1
	ember-data/attr                                   | 218.00 B  | 41.64 B    | 2.5           | 0.1
	ember-data/version                                | 161.00 B  | 30.75 B    | 1.8           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.71 KB' │
│  compressed  │ '1.28 KB' │
│ % Of Library │   '3.3'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 3.00 KB   | 587.27 B   | 44.8          | 1.5
	ember-inflector/lib/system/inflections            | 1.59 KB   | 310.83 B   | 23.7          | 0.8
	ember-inflector/lib/system                        | 471.00 B  | 89.98 B    | 6.9           | 0.2
	ember-inflector/index                             | 379.00 B  | 72.40 B    | 5.5           | 0.2
	ember-inflector/lib/helpers/pluralize             | 369.00 B  | 70.49 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 332.00 B  | 63.42 B    | 4.8           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 60.75 B    | 4.6           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 56.54 B    | 4.3           | 0.1

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.77 KB'  │
│  compressed  │ '541.23 B' │
│ % Of Library │   '1.4'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.27 KB   | 444.75 B   | 82.2          | 1.1
	@ember-data/debug/setup                           | 505.00 B  | 96.47 B    | 17.8          | 0.2

github-actions · 2022-10-13T22:50:27Z

Performance Report for 027da7c

Scenario - basic-record-materialization: ☑️ Performance is stable

☑️ duration
phase no difference [-20ms to 31ms]
☑️ Phase [navigationStart] => [start-data-generation]
phase no difference [-3ms to 3ms]
☑️ Phase [start-data-generation] => [start-push-payload]
phase no difference [-1ms to 3ms]
☑️ Phase [start-push-payload] => [start-peek-records]
phase no difference [-2ms to 16ms]
☑️ Phase [start-peek-records] => [start-record-materialization]
phase no difference [0ms to 0ms]
☑️ Phase [start-record-materialization] => [end-record-materialization]
phase no difference [-8ms to 20ms]
☑️ Phase [end-record-materialization] => [Test End]
phase no difference [-13ms to 0ms]

Scenario - relationship-materialization-simple: ☑️ Performance is stable

☑️ duration
phase no difference [-5ms to 10ms]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-4ms to 2ms]
☑️ Phase [start-find-all] => [start-materialization]
phase no difference [-2ms to 6ms]
☑️ Phase [start-materialization] => [end-materialization]
phase no difference [-3ms to 4ms]
☑️ Phase [end-materialization] => [Test End]
phase no difference [0ms to 1ms]

Scenario - relationship-materialization-complex: ☑️ Performance is stable

☑️ duration
phase no difference [-24ms to 22ms]
☑️ Phase [navigationStart] => [start-data-generation]
phase no difference [-3ms to 2ms]
☑️ Phase [start-data-generation] => [start-push-payload]
phase no difference [-1ms to 1ms]
☑️ Phase [start-push-payload] => [start-peek-records]
phase no difference [-2ms to 8ms]
☑️ Phase [start-peek-records] => [start-record-materialization]
phase no difference [0ms to 0ms]
⚠️ Phase [start-record-materialization] => [start-relationship-materialization]
phase estimated regression +4ms [0ms to 7ms] OR +1.68% [0.21% to 3.08%]
☑️ Phase [start-relationship-materialization] => [end-relationship-materialization]
phase no difference [-25ms to 6ms]
☑️ Phase [end-relationship-materialization] => [Test End]
phase no difference [-2ms to 3ms]

Scenario - unload: ☑️ Performance is stable

☑️ duration
phase no difference [-17ms to 6ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-4ms to 2ms]
☑️ Phase [start-push-payload] => [start-unload-records]
phase no difference [-2ms to 4ms]
☑️ Phase [start-unload-records] => [end-unload-records]
phase no difference [-8ms to 3ms]
☑️ Phase [end-unload-records] => [Test End]
phase no difference [0ms to 0ms]

Scenario - unload-all: ✅ Performance improved

✅ duration
phase estimated improvement -13ms [-23ms to -3ms] OR -0.64% [-1.14% to -0.15%]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-1ms to 4ms]
✅ Phase [start-push-payload] => [start-materialization]
phase estimated improvement -9ms [-13ms to -4ms] OR -1.02% [-1.58% to -0.45%]
✅ Phase [start-materialization] => [start-unload-all]
phase estimated improvement -6ms [-8ms to -3ms] OR -1.87% [-2.78% to -1.02%]
☑️ Phase [start-unload-all] => [end-unload-all]
phase no difference [-5ms to 2ms]
☑️ Phase [end-unload-all] => [Test End]
phase no difference [0ms to 0ms]

Scenario - destroy: ☑️ Performance is stable

☑️ duration
phase no difference [-8ms to 10ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-3ms to 3ms]
☑️ Phase [start-push-payload] => [start-destroy-records]
phase no difference [-5ms to 1ms]
☑️ Phase [start-destroy-records] => [end-destroy-records]
phase no difference [-1ms to 4ms]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [0ms to 0ms]

Scenario - add-children: ☑️ Performance is stable

☑️ duration
phase no difference [-10ms to 2ms]
☑️ Phase [navigationStart] => [start-push-initial-payload]
phase no difference [-8ms to 2ms]
☑️ Phase [start-push-initial-payload] => [start-push-update-payload]
phase no difference [-3ms to 2ms]
☑️ Phase [start-push-update-payload] => [end-push-update-payload]
phase no difference [-1ms to 2ms]
☑️ Phase [end-push-update-payload] => [Test End]
phase no difference [0ms to 0ms]

Scenario - unused-relationships: ☑️ Performance is stable

☑️ duration
phase no difference [-6ms to 8ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-3ms to 2ms]
☑️ Phase [start-push-payload] => [end-push-payload]
phase no difference [0ms to 7ms]
☑️ Phase [end-push-payload] => [Test End]
phase no difference [0ms to 0ms]

github-actions · 2022-10-13T23:03:06Z

Commit v Release Performance Report for 027da7c

Scenario - basic-record-materialization: ☑️ Performance is stable

☑️ duration
phase no difference [-8ms to 60ms]
☑️ Phase [navigationStart] => [start-data-generation]
phase no difference [-5ms to 0ms]
⚠️ Phase [start-data-generation] => [start-push-payload]
phase estimated regression +5ms [3ms to 7ms] OR +1.26% [0.84% to 1.72%]
☑️ Phase [start-push-payload] => [start-peek-records]
phase no difference [-6ms to 8ms]
☑️ Phase [start-peek-records] => [start-record-materialization]
phase no difference [0ms to 0ms]
☑️ Phase [start-record-materialization] => [end-record-materialization]
phase no difference [-6ms to 25ms]
☑️ Phase [end-record-materialization] => [Test End]
phase no difference [-1ms to 2ms]

Scenario - relationship-materialization-simple: ☑️ Performance is stable

☑️ duration
phase no difference [-8ms to 9ms]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-3ms to 3ms]
☑️ Phase [start-find-all] => [start-materialization]
phase no difference [-4ms to 4ms]
☑️ Phase [start-materialization] => [end-materialization]
phase no difference [-5ms to 2ms]
☑️ Phase [end-materialization] => [Test End]
phase no difference [0ms to 0ms]

Scenario - relationship-materialization-complex: ☑️ Performance is stable

☑️ duration
phase no difference [-21ms to 17ms]
☑️ Phase [navigationStart] => [start-data-generation]
phase no difference [-3ms to 2ms]
⚠️ Phase [start-data-generation] => [start-push-payload]
phase estimated regression +7ms [6ms to 8ms] OR +3.61% [3.21% to 4.01%]
☑️ Phase [start-push-payload] => [start-peek-records]
phase no difference [-1ms to 8ms]
☑️ Phase [start-peek-records] => [start-record-materialization]
phase no difference [0ms to 0ms]
☑️ Phase [start-record-materialization] => [start-relationship-materialization]
phase no difference [-6ms to 0ms]
☑️ Phase [start-relationship-materialization] => [end-relationship-materialization]
phase no difference [-27ms to 9ms]
☑️ Phase [end-relationship-materialization] => [Test End]
phase no difference [-3ms to 4ms]

Scenario - unload: ☑️ Performance is stable

☑️ duration
phase no difference [-9ms to 7ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-3ms to 4ms]
☑️ Phase [start-push-payload] => [start-unload-records]
phase no difference [-3ms to 3ms]
☑️ Phase [start-unload-records] => [end-unload-records]
phase no difference [-3ms to 1ms]
☑️ Phase [end-unload-records] => [Test End]
phase no difference [0ms to 0ms]

Scenario - unload-all: ☑️ Performance is stable

☑️ duration
phase no difference [-10ms to 13ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-5ms to 1ms]
☑️ Phase [start-push-payload] => [start-materialization]
phase no difference [0ms to 8ms]
⚠️ Phase [start-materialization] => [start-unload-all]
phase estimated regression +4ms [1ms to 6ms] OR +1.28% [0.48% to 2.07%]
☑️ Phase [start-unload-all] => [end-unload-all]
phase no difference [-6ms to 1ms]
☑️ Phase [end-unload-all] => [Test End]
phase no difference [0ms to 0ms]

Scenario - destroy: ☑️ Performance is stable

☑️ duration
phase no difference [-9ms to 9ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-5ms to 3ms]
☑️ Phase [start-push-payload] => [start-destroy-records]
phase no difference [-2ms to 4ms]
☑️ Phase [start-destroy-records] => [end-destroy-records]
phase no difference [-3ms to 2ms]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [0ms to 0ms]

Scenario - add-children: ☑️ Performance is stable

☑️ duration
phase no difference [-7ms to 6ms]
☑️ Phase [navigationStart] => [start-push-initial-payload]
phase no difference [-7ms to 4ms]
☑️ Phase [start-push-initial-payload] => [start-push-update-payload]
phase no difference [-2ms to 2ms]
☑️ Phase [start-push-update-payload] => [end-push-update-payload]
phase no difference [-1ms to 2ms]
☑️ Phase [end-push-update-payload] => [Test End]
phase no difference [0ms to 0ms]

Scenario - unused-relationships: ☑️ Performance is stable

☑️ duration
phase no difference [-6ms to 9ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-3ms to 4ms]
☑️ Phase [start-push-payload] => [end-push-payload]
phase no difference [-3ms to 4ms]
☑️ Phase [end-push-payload] => [Test End]
phase no difference [0ms to 0ms]

runspired · 2022-10-14T06:02:59Z

This is at least part of #8173

sly7-7 · 2022-10-17T09:45:24Z

packages/store/addon/-private/proxies/promise-proxies.ts

@@ -105,6 +107,7 @@ function _promiseArray<I, T extends EmberArrayLike<I>>(promise: Promise<T>, labe

 // constructor is accessed in some internals but not including it in the copyright for the deprecation
 const ALLOWABLE_METHODS = ['constructor', 'then', 'catch', 'finally'];
+const ALLOWABLE_PROPS = ['__ec_yieldable__', '__ec_cancel__'];


I've opened an issue in EC concerning this: machty/ember-concurrency#496, do you think it's legit, or should I close it ?

Still a real issue though probably not terribly bad

Ok, thank you, I will wait for feedback in EC then.

runspired added 3 commits October 13, 2022 14:53

npm ignore publish for yarn-error.log

0d782df

dont wrap in deprecation proxy in prod builds

08d6d43

add failing test to replicate bug

e467bd6

runspired added 2 commits October 13, 2022 17:12

add fix

2bd896c

restore original deprecation

bc6a9b9

runspired added 🎯 release PR should be backported to release 🎯 canary PR is targeting canary (default) 🏷️ bug This PR primarily fixes a reported issue labels Oct 14, 2022

runspired added 3 commits October 13, 2022 17:50

cleanup

5625c87

more cleanup

cd5b5ed

dont deprecate for ec, fix prod test

027da7c

runspired changed the title ~~bug: MandatorySetter error for Proxied PromiseProxy~~ fix: fix MandatorySetter error for Proxied PromiseProxy, silence ember-concurrency deprecations Oct 14, 2022

runspired merged commit 1b35d2a into master Oct 14, 2022

delete-merged-branch bot deleted the fix-promise-tracking branch October 14, 2022 06:34

sly7-7 reviewed Oct 17, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: fix MandatorySetter error for Proxied PromiseProxy, silence ember-concurrency deprecations #8206

fix: fix MandatorySetter error for Proxied PromiseProxy, silence ember-concurrency deprecations #8206

runspired commented Oct 13, 2022 •

edited

github-actions bot commented Oct 13, 2022 •

edited

github-actions bot commented Oct 13, 2022 •

edited

github-actions bot commented Oct 13, 2022 •

edited

runspired commented Oct 14, 2022

sly7-7 Oct 17, 2022

runspired Oct 17, 2022

sly7-7 Oct 18, 2022

fix: fix MandatorySetter error for Proxied PromiseProxy, silence ember-concurrency deprecations #8206

fix: fix MandatorySetter error for Proxied PromiseProxy, silence ember-concurrency deprecations #8206

Conversation

runspired commented Oct 13, 2022 • edited

github-actions bot commented Oct 13, 2022 • edited

github-actions bot commented Oct 13, 2022 • edited

github-actions bot commented Oct 13, 2022 • edited

runspired commented Oct 14, 2022

sly7-7 Oct 17, 2022

Choose a reason for hiding this comment

runspired Oct 17, 2022

Choose a reason for hiding this comment

sly7-7 Oct 18, 2022

Choose a reason for hiding this comment

runspired commented Oct 13, 2022 •

edited

github-actions bot commented Oct 13, 2022 •

edited

github-actions bot commented Oct 13, 2022 •

edited

github-actions bot commented Oct 13, 2022 •

edited