Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ManyReference.value should recompute when data is first received #8211

Merged
merged 1 commit into from Oct 14, 2022

Conversation

runspired
Copy link
Contributor

resolves #8187

@runspired runspired added 🎯 release PR should be backported to release 🎯 canary PR is targeting canary (default) 🏷️ bug This PR primarily fixes a reported issue labels Oct 14, 2022
@github-actions
Copy link

Asset Size Report for 0a608b2

Modern Builds

EmberData increased by -12.0 B (+30.0 B compressed) which is within the allowed tolerance of 75 bytes uncompressed

Warnings

⚠️ The uncompressed size of the package @ember-data/model has increased by +12.0 B.

Changeset


EmberData 165.22 KB +12.0 B (35.31 KB +30.0 B compressed)
    @ember-data/model 44.76 KB +12.0 B (9.57 KB +30.0 B compressed)
        @ember-data/model/-private 44.29 KB +12.0 B (9.46 KB +30.0 B compressed)

Full Asset Analysis (Modern)

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '165.22 KB' │
│ compressed │ '35.31 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '44.76 KB' │
│  compressed  │ '9.57 KB'  │
│ % Of Library │   '27.1'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 44.29 KB  | 9.46 KB    | 98.9          | 26.8
	@ember-data/model/index                           | 486.00 B  | 103.86 B   | 1.1           | 0.3

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '42.96 KB' │
│  compressed  │ '9.18 KB'  │
│ % Of Library │   '26.0'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 41.96 KB  | 8.97 KB    | 97.7          | 25.4
	@ember-data/store/index                           | 1022.00 B | 218.42 B   | 2.3           | 0.6

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '23.36 KB' │
│  compressed  │ '4.99 KB'  │
│ % Of Library │   '14.1'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 23.36 KB  | 4.99 KB    | 100.0         | 14.1

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '20.42 KB' │
│  compressed  │ '4.36 KB'  │
│ % Of Library │   '12.4'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.36 KB   | 1.57 KB    | 36.0          | 4.5
	@ember-data/serializer/-private                   | 5.60 KB   | 1.20 KB    | 27.4          | 3.4
	@ember-data/serializer/json-api                   | 3.79 KB   | 829.45 B   | 18.6          | 2.3
	@ember-data/serializer/rest                       | 2.87 KB   | 627.05 B   | 14.0          | 1.7
	@ember-data/serializer/index                      | 611.00 B  | 130.58 B   | 2.9           | 0.4
	@ember-data/serializer/transform                  | 215.00 B  | 45.95 B    | 1.0           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '15.93 KB' │
│  compressed  │ '3.41 KB'  │
│ % Of Library │   '9.6'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 7.88 KB   | 1.68 KB    | 49.5          | 4.8
	@ember-data/adapter/-private                      | 3.79 KB   | 828.38 B   | 23.8          | 2.3
	@ember-data/adapter/error                         | 1.82 KB   | 398.80 B   | 11.4          | 1.1
	@ember-data/adapter/index                         | 1.41 KB   | 309.04 B   | 8.9           | 0.9
	@ember-data/adapter/json-api                      | 1.03 KB   | 226.33 B   | 6.5           | 0.6

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '8.32 KB' │
│  compressed  │ '1.78 KB' │
│ % Of Library │   '5.0'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 1.98 KB   | 434.28 B   | 23.8          | 1.2
	ember-data/-private                               | 1.53 KB   | 335.75 B   | 18.4          | 0.9
	ember-data/adapters/errors                        | 1.19 KB   | 260.09 B   | 14.3          | 0.7
	ember-data/setup-container                        | 368.00 B  | 78.64 B    | 4.3           | 0.2
	ember-data/relationships                          | 318.00 B  | 67.96 B    | 3.7           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 58.55 B    | 3.2           | 0.2
	ember-data/serializers/json-api                   | 251.00 B  | 53.64 B    | 2.9           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 52.36 B    | 2.9           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 51.93 B    | 2.9           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 51.93 B    | 2.9           | 0.1
	ember-data/transform                              | 241.00 B  | 51.50 B    | 2.8           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 50.65 B    | 2.8           | 0.1
	ember-data/serializer                             | 232.00 B  | 49.58 B    | 2.7           | 0.1
	ember-data/adapter                                | 226.00 B  | 48.30 B    | 2.7           | 0.1
	ember-data/model                                  | 222.00 B  | 47.44 B    | 2.6           | 0.1
	ember-data/store                                  | 222.00 B  | 47.44 B    | 2.6           | 0.1
	ember-data/attr                                   | 218.00 B  | 46.59 B    | 2.6           | 0.1
	ember-data/version                                | 161.00 B  | 34.40 B    | 1.9           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.71 KB' │
│  compressed  │ '1.43 KB' │
│ % Of Library │   '4.1'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 3.00 KB   | 656.97 B   | 44.8          | 1.8
	ember-inflector/lib/system/inflections            | 1.59 KB   | 347.72 B   | 23.7          | 1.0
	ember-inflector/lib/system                        | 471.00 B  | 100.66 B   | 6.9           | 0.3
	ember-inflector/index                             | 379.00 B  | 81.00 B    | 5.5           | 0.2
	ember-inflector/lib/helpers/pluralize             | 369.00 B  | 78.86 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 332.00 B  | 70.95 B    | 4.8           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 67.96 B    | 4.6           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 63.26 B    | 4.3           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.77 KB'  │
│  compressed  │ '605.47 B' │
│ % Of Library │   '1.7'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.27 KB   | 497.54 B   | 82.2          | 1.4
	@ember-data/debug/setup                           | 505.00 B  | 107.92 B   | 17.8          | 0.3

Modern Builds (No Rollup)

EmberData increased by -12.0 B (+12.0 B compressed) which is within the allowed tolerance of 75 bytes uncompressed

Warnings

⚠️ The uncompressed size of the package @ember-data/model has increased by +12.0 B.

Changeset


EmberData 203.6 KB +12.0 B (38.91 KB +12.0 B compressed)
    @ember-data/model 50.84 KB +12.0 B (9.71 KB +12.0 B compressed)
        @ember-data/model/-private/references/has-many 3.21 KB +12.0 B (628.69 B +12.0 B compressed)

Full Asset Analysis (Modern)

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '203.60 KB' │
│ compressed │ '38.91 KB'  │
│  packages  │      8      │
│  modules   │     126     │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '63.44 KB' │
│  compressed  │ '12.12 KB' │
│ % Of Library │   '31.2'   │
└──────────────┴────────────┘
	Module                                                                        | Bytes     | Compressed | % of Package  | % Of Library
	---------------------------------------------------------------------------------------------------------------------------------
	@ember-data/store/-private/store-service                                      | 10.59 KB  | 2.02 KB    | 16.7          | 5.2
	@ember-data/store/-private/managers/record-data-manager                       | 7.90 KB   | 1.51 KB    | 12.5          | 3.9
	@ember-data/store/-private/caches/instance-cache                              | 5.90 KB   | 1.13 KB    | 9.3           | 2.9
	@ember-data/store/-private/network/fetch-manager                              | 4.89 KB   | 956.04 B   | 7.7           | 2.4
	@ember-data/store/-private/record-arrays/identifier-array                     | 4.27 KB   | 835.27 B   | 6.7           | 2.1
	@ember-data/store/-private/caches/identifier-cache                            | 3.66 KB   | 716.60 B   | 5.8           | 1.8
	@ember-data/store/-private/network/snapshot                                   | 3.31 KB   | 647.80 B   | 5.2           | 1.6
	@ember-data/store/-private/managers/record-array-manager                      | 3.07 KB   | 601.37 B   | 4.8           | 1.5
	@ember-data/store/-private/index                                              | 2.74 KB   | 535.25 B   | 4.3           | 1.3
	@ember-data/store/-private/managers/record-data-store-wrapper                 | 1.62 KB   | 317.59 B   | 2.6           | 0.8
	@ember-data/store/-private/network/request-cache                              | 1.61 KB   | 314.15 B   | 2.5           | 0.8
	@ember-data/store/-private/legacy-model-support/shim-model-class              | 1.55 KB   | 302.50 B   | 2.4           | 0.8
	@ember-data/store/-private/network/finders                                    | 1.51 KB   | 296.19 B   | 2.4           | 0.7
	@ember-data/store/-private/legacy-model-support/schema-definition-service     | 1.37 KB   | 268.86 B   | 2.2           | 0.7
	@ember-data/store/-private/legacy-model-support/record-reference              | 1.34 KB   | 261.98 B   | 2.1           | 0.7
	@ember-data/store/-private/proxies/promise-proxies                            | 1.09 KB   | 213.45 B   | 1.7           | 0.5
	@ember-data/store/index                                                       | 1022.00 B | 195.29 B   | 1.6           | 0.5
	@ember-data/store/-private/utils/uuid-polyfill                                | 786.00 B  | 150.19 B   | 1.2           | 0.4
	@ember-data/store/-private/managers/record-notification-manager               | 753.00 B  | 143.89 B   | 1.2           | 0.4
	@ember-data/store/-private/network/snapshot-record-array                      | 691.00 B  | 132.04 B   | 1.1           | 0.3
	@ember-data/store/-private/utils/construct-resource                           | 688.00 B  | 131.47 B   | 1.1           | 0.3
	@ember-data/store/-private/utils/common                                       | 572.00 B  | 109.30 B   | 0.9           | 0.3
	@ember-data/store/-private/utils/coerce-id                                    | 473.00 B  | 90.38 B    | 0.7           | 0.2
	@ember-data/store/-private/proxies/promise-proxy-base                         | 403.00 B  | 77.01 B    | 0.6           | 0.2
	@ember-data/store/-private/caches/record-data-for                             | 325.00 B  | 62.10 B    | 0.5           | 0.2
	@ember-data/store/-private/utils/identifer-debug-consts                       | 304.00 B  | 58.09 B    | 0.5           | 0.1
	@ember-data/store/-private/utils/promise-record                               | 291.00 B  | 55.60 B    | 0.4           | 0.1
	@ember-data/store/-private/utils/serializer-response                          | 258.00 B  | 49.30 B    | 0.4           | 0.1
	@ember-data/store/-private/utils/normalize-model-name                         | 219.00 B  | 41.84 B    | 0.3           | 0.1
	@ember-data/store/-debug/index                                                | 207.00 B  | 39.55 B    | 0.3           | 0.1
	@ember-data/store/-private/utils/is-non-empty-string                          | 204.00 B  | 38.98 B    | 0.3           | 0.1

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '50.84 KB' │
│  compressed  │ '9.71 KB'  │
│ % Of Library │   '25.0'   │
└──────────────┴────────────┘
	Module                                                      | Bytes     | Compressed | % of Package  | % Of Library
	---------------------------------------------------------------------------------------------------------------
	@ember-data/model/-private/model                            | 11.25 KB  | 2.15 KB    | 22.1          | 5.5
	@ember-data/model/-private/legacy-relationships-support     | 7.94 KB   | 1.52 KB    | 15.6          | 3.9
	@ember-data/model/-private/record-state                     | 6.52 KB   | 1.25 KB    | 12.8          | 3.2
	@ember-data/model/-private/references/has-many              | 3.21 KB   | 628.69 B   | 6.3           | 1.6
	@ember-data/model/-private/references/belongs-to            | 2.81 KB   | 550.54 B   | 5.5           | 1.4
	@ember-data/model/-private/promise-many-array               | 2.70 KB   | 528.75 B   | 5.3           | 1.3
	@ember-data/model/-private/legacy-data-fetch                | 2.59 KB   | 506.01 B   | 5.1           | 1.3
	@ember-data/model/-private/many-array                       | 2.35 KB   | 459.38 B   | 4.6           | 1.2
	@ember-data/model/-private/errors                           | 2.31 KB   | 451.93 B   | 4.5           | 1.1
	@ember-data/model/-private/index                            | 1.48 KB   | 290.27 B   | 2.9           | 0.7
	@ember-data/model/-private/relationship-meta                | 991.00 B  | 189.37 B   | 1.9           | 0.5
	@ember-data/model/-private/notify-changes                   | 913.00 B  | 174.46 B   | 1.8           | 0.4
	@ember-data/model/-private/attr                             | 839.00 B  | 160.32 B   | 1.6           | 0.4
	@ember-data/model/-private/has-many                         | 817.00 B  | 156.12 B   | 1.6           | 0.4
	@ember-data/model/-private/belongs-to                       | 736.00 B  | 140.64 B   | 1.4           | 0.4
	@ember-data/model/-private/promise-belongs-to               | 615.00 B  | 117.52 B   | 1.2           | 0.3
	@ember-data/model/-private/util                             | 522.00 B  | 99.75 B    | 1.0           | 0.3
	@ember-data/model/index                                     | 486.00 B  | 92.87 B    | 0.9           | 0.2
	@ember-data/model/-private/diff-array                       | 445.00 B  | 85.03 B    | 0.9           | 0.2
	@ember-data/model/-private/model-for-mixin                  | 407.00 B  | 77.77 B    | 0.8           | 0.2
	@ember-data/model/-private/deprecated-promise-proxy         | 403.00 B  | 77.01 B    | 0.8           | 0.2
	@ember-data/model/-private/legacy-data-utils                | 395.00 B  | 75.48 B    | 0.8           | 0.2
	@ember-data/model/-private/promise-proxy-base               | 284.00 B  | 54.27 B    | 0.5           | 0.1

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '30.75 KB' │
│  compressed  │ '5.88 KB'  │
│ % Of Library │   '15.1'   │
└──────────────┴────────────┘
	Module                                                                            | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private/record-data                                      | 7.17 KB   | 1.37 KB    | 23.3          | 3.5
	@ember-data/record-data/-private/graph/graph                                      | 5.89 KB   | 1.12 KB    | 19.1          | 2.9
	@ember-data/record-data/-private/graph/operations/replace-related-records         | 3.63 KB   | 711.06 B   | 11.8          | 1.8
	@ember-data/record-data/-private/graph/-edge-definition                           | 3.12 KB   | 609.78 B   | 10.1          | 1.5
	@ember-data/record-data/-private/graph/-utils                                     | 2.10 KB   | 411.80 B   | 6.8           | 1.0
	@ember-data/record-data/-private/graph/operations/update-relationship             | 1.51 KB   | 295.62 B   | 4.9           | 0.7
	@ember-data/record-data/-private/graph/operations/merge-identifier                | 1.26 KB   | 246.32 B   | 4.1           | 0.6
	@ember-data/record-data/-private/graph/operations/replace-related-record          | 1.21 KB   | 236.76 B   | 3.9           | 0.6
	@ember-data/record-data/-private/graph/operations/add-to-related-records          | 829.00 B  | 158.41 B   | 2.6           | 0.4
	@ember-data/record-data/-private/graph/operations/remove-from-related-records     | 708.00 B  | 135.29 B   | 2.2           | 0.3
	@ember-data/record-data/-private/relationships/state/belongs-to                   | 707.00 B  | 135.10 B   | 2.2           | 0.3
	@ember-data/record-data/-private/relationships/state/has-many                     | 692.00 B  | 132.23 B   | 2.2           | 0.3
	@ember-data/record-data/-private/index                                            | 497.00 B  | 94.97 B    | 1.6           | 0.2
	@ember-data/record-data/-private/graph/index                                      | 482.00 B  | 92.10 B    | 1.5           | 0.2
	@ember-data/record-data/-private/coerce-id                                        | 379.00 B  | 72.42 B    | 1.2           | 0.2
	@ember-data/record-data/-private/graph/-state                                     | 293.00 B  | 55.99 B    | 0.9           | 0.1
	@ember-data/record-data/-private/normalize-link                                   | 238.00 B  | 45.48 B    | 0.8           | 0.1
	@ember-data/record-data/-private/graph/-operations                                | 150.00 B  | 28.66 B    | 0.5           | 0.1

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '22.43 KB' │
│  compressed  │ '4.29 KB'  │
│ % Of Library │   '11.0'   │
└──────────────┴────────────┘
	Module                                                     | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                                | 7.36 KB   | 1.41 KB    | 32.8          | 3.6
	@ember-data/serializer/-private/embedded-records-mixin     | 4.59 KB   | 898.90 B   | 20.5          | 2.3
	@ember-data/serializer/json-api                            | 3.79 KB   | 741.63 B   | 16.9          | 1.9
	@ember-data/serializer/rest                                | 2.87 KB   | 560.66 B   | 12.8          | 1.4
	@ember-data/serializer/-private/index                      | 1018.00 B | 194.53 B   | 4.4           | 0.5
	@ember-data/serializer/index                               | 611.00 B  | 116.75 B   | 2.7           | 0.3
	@ember-data/serializer/-private/transforms/date            | 530.00 B  | 101.27 B   | 2.3           | 0.3
	@ember-data/serializer/-private/transforms/boolean         | 504.00 B  | 96.31 B    | 2.2           | 0.2
	@ember-data/serializer/-private/transforms/number          | 439.00 B  | 83.89 B    | 1.9           | 0.2
	@ember-data/serializer/-private/transforms/string          | 371.00 B  | 70.89 B    | 1.6           | 0.2
	@ember-data/serializer/-private/transforms/transform       | 226.00 B  | 43.18 B    | 1.0           | 0.1
	@ember-data/serializer/transform                           | 215.00 B  | 41.08 B    | 0.9           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '18.04 KB' │
│  compressed  │ '3.45 KB'  │
│ % Of Library │   '8.9'    │
└──────────────┴────────────┘
	Module                                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                                      | 7.88 KB   | 1.51 KB    | 43.7          | 3.9
	@ember-data/adapter/-private/build-url-mixin                  | 1.92 KB   | 375.30 B   | 10.6          | 0.9
	@ember-data/adapter/error                                     | 1.82 KB   | 356.58 B   | 10.1          | 0.9
	@ember-data/adapter/index                                     | 1.41 KB   | 276.32 B   | 7.8           | 0.7
	@ember-data/adapter/json-api                                  | 1.03 KB   | 202.36 B   | 5.7           | 0.5
	@ember-data/adapter/-private/index                            | 1.03 KB   | 201.79 B   | 5.7           | 0.5
	@ember-data/adapter/-private/utils/serialize-query-params     | 769.00 B  | 146.95 B   | 4.2           | 0.4
	@ember-data/adapter/-private/utils/determine-body-promise     | 556.00 B  | 106.24 B   | 3.0           | 0.3
	@ember-data/adapter/-private/utils/parse-response-headers     | 488.00 B  | 93.25 B    | 2.6           | 0.2
	@ember-data/adapter/-private/utils/fetch                      | 450.00 B  | 85.99 B    | 2.4           | 0.2
	@ember-data/adapter/-private/utils/serialize-into-hash        | 382.00 B  | 72.99 B    | 2.1           | 0.2
	@ember-data/adapter/-private/utils/continue-on-reject         | 222.00 B  | 42.42 B    | 1.2           | 0.1
	@ember-data/adapter/-private/fastboot-interface               | 147.00 B  | 28.09 B    | 0.8           | 0.1

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '8.64 KB' │
│  compressed  │ '1.65 KB' │
│ % Of Library │   '4.2'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 1.98 KB   | 388.30 B   | 23.0          | 1.0
	ember-data/-private/index                         | 1.49 KB   | 291.79 B   | 17.3          | 0.7
	ember-data/adapters/errors                        | 1.19 KB   | 232.56 B   | 13.8          | 0.6
	ember-data/-private/core                          | 368.00 B  | 70.32 B    | 4.2           | 0.2
	ember-data/setup-container                        | 368.00 B  | 70.32 B    | 4.2           | 0.2
	ember-data/relationships                          | 318.00 B  | 60.76 B    | 3.6           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 52.35 B    | 3.1           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 47.96 B    | 2.8           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 46.81 B    | 2.8           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 46.43 B    | 2.7           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 46.43 B    | 2.7           | 0.1
	ember-data/transform                              | 241.00 B  | 46.05 B    | 2.7           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 45.28 B    | 2.7           | 0.1
	ember-data/serializer                             | 232.00 B  | 44.33 B    | 2.6           | 0.1
	ember-data/adapter                                | 226.00 B  | 43.18 B    | 2.6           | 0.1
	ember-data/model                                  | 222.00 B  | 42.42 B    | 2.5           | 0.1
	ember-data/store                                  | 222.00 B  | 42.42 B    | 2.5           | 0.1
	ember-data/attr                                   | 218.00 B  | 41.65 B    | 2.5           | 0.1
	ember-data/version                                | 161.00 B  | 30.76 B    | 1.8           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.71 KB' │
│  compressed  │ '1.28 KB' │
│ % Of Library │   '3.3'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 3.00 KB   | 587.42 B   | 44.8          | 1.5
	ember-inflector/lib/system/inflections            | 1.59 KB   | 310.90 B   | 23.7          | 0.8
	ember-inflector/lib/system                        | 471.00 B  | 90.00 B    | 6.9           | 0.2
	ember-inflector/index                             | 379.00 B  | 72.42 B    | 5.5           | 0.2
	ember-inflector/lib/helpers/pluralize             | 369.00 B  | 70.51 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 332.00 B  | 63.44 B    | 4.8           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 60.76 B    | 4.6           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 56.56 B    | 4.3           | 0.1

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.77 KB'  │
│  compressed  │ '541.36 B' │
│ % Of Library │   '1.4'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.27 KB   | 444.85 B   | 82.2          | 1.1
	@ember-data/debug/setup                           | 505.00 B  | 96.50 B    | 17.8          | 0.2

@runspired runspired merged commit 7dbf6be into master Oct 14, 2022
@delete-merged-branch delete-merged-branch bot deleted the runspired-fix-ref-tracking branch October 14, 2022 07:38
@github-actions
Copy link

github-actions bot commented Oct 14, 2022

Performance Report for 0a608b2

Scenario - basic-record-materialization: ☑️ Performance is stable

☑️ duration
phase no difference [-9ms to 52ms]
☑️ Phase [navigationStart] => [start-data-generation]
phase no difference [-5ms to 5ms]
☑️ Phase [start-data-generation] => [start-push-payload]
phase no difference [-1ms to 5ms]
☑️ Phase [start-push-payload] => [start-peek-records]
phase no difference [-11ms to 11ms]
☑️ Phase [start-peek-records] => [start-record-materialization]
phase no difference [0ms to 0ms]
☑️ Phase [start-record-materialization] => [end-record-materialization]
phase no difference [-8ms to 17ms]
☑️ Phase [end-record-materialization] => [Test End]
phase no difference [0ms to 12ms]

Scenario - relationship-materialization-simple: ☑️ Performance is stable

☑️ duration
phase no difference [-16ms to 6ms]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-8ms to 3ms]
☑️ Phase [start-find-all] => [start-materialization]
phase no difference [-6ms to 3ms]
☑️ Phase [start-materialization] => [end-materialization]
phase no difference [-2ms to 4ms]
☑️ Phase [end-materialization] => [Test End]
phase no difference [-1ms to 0ms]

Scenario - relationship-materialization-complex: ☑️ Performance is stable

☑️ duration
phase no difference [-50ms to 38ms]
☑️ Phase [navigationStart] => [start-data-generation]
phase no difference [-3ms to 6ms]
☑️ Phase [start-data-generation] => [start-push-payload]
phase no difference [-2ms to 4ms]
☑️ Phase [start-push-payload] => [start-peek-records]
phase no difference [-5ms to 7ms]
☑️ Phase [start-peek-records] => [start-record-materialization]
phase no difference [0ms to 0ms]
☑️ Phase [start-record-materialization] => [start-relationship-materialization]
phase no difference [-2ms to 6ms]
☑️ Phase [start-relationship-materialization] => [end-relationship-materialization]
phase no difference [-47ms to 29ms]
☑️ Phase [end-relationship-materialization] => [Test End]
phase no difference [-5ms to 3ms]

Scenario - unload: ☑️ Performance is stable

☑️ duration
phase no difference [-19ms to 6ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-13ms to 5ms]
☑️ Phase [start-push-payload] => [start-unload-records]
phase no difference [-4ms to 5ms]
☑️ Phase [start-unload-records] => [end-unload-records]
phase no difference [-4ms to 2ms]
✅ Phase [end-unload-records] => [Test End]
phase estimated improvement -1ms [-1ms to 0ms] OR -1.28% [-2.56% to -0.08%]

Scenario - unload-all: ☑️ Performance is stable

☑️ duration
phase no difference [-18ms to 14ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-9ms to 7ms]
☑️ Phase [start-push-payload] => [start-materialization]
phase no difference [-13ms to 1ms]
☑️ Phase [start-materialization] => [start-unload-all]
phase no difference [-3ms to 5ms]
☑️ Phase [start-unload-all] => [end-unload-all]
phase no difference [-2ms to 8ms]
✅ Phase [end-unload-all] => [Test End]
phase estimated improvement -1ms [-1ms to 0ms] OR -1.93% [-3.05% to -0.69%]

Scenario - destroy: ☑️ Performance is stable

☑️ duration
phase no difference [-22ms to 2ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-13ms to 6ms]
✅ Phase [start-push-payload] => [start-destroy-records]
phase estimated improvement -6ms [-11ms to -1ms] OR -0.99% [-1.76% to -0.2%]
☑️ Phase [start-destroy-records] => [end-destroy-records]
phase no difference [-2ms to 4ms]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [-1ms to 0ms]

Scenario - add-children: ☑️ Performance is stable

☑️ duration
phase no difference [-18ms to 1ms]
☑️ Phase [navigationStart] => [start-push-initial-payload]
phase no difference [-12ms to 3ms]
☑️ Phase [start-push-initial-payload] => [start-push-update-payload]
phase no difference [-3ms to 2ms]
☑️ Phase [start-push-update-payload] => [end-push-update-payload]
phase no difference [-4ms to 1ms]
☑️ Phase [end-push-update-payload] => [Test End]
phase no difference [-1ms to 0ms]

Scenario - unused-relationships: ☑️ Performance is stable

☑️ duration
phase no difference [-10ms to 19ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-10ms to 11ms]
⚠️ Phase [start-push-payload] => [end-push-payload]
phase estimated regression +4ms [0ms to 9ms] OR +0.74% [0.01% to 1.44%]
☑️ Phase [end-push-payload] => [Test End]
phase no difference [0ms to 1ms]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 canary PR is targeting canary (default) 🎯 release PR should be backported to release 🏷️ bug This PR primarily fixes a reported issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ManyReference.value() is not tracked
1 participant