Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: inspector type detection 2. attempt #8205 #8215

Merged
merged 2 commits into from Oct 14, 2022
Merged

fix: inspector type detection 2. attempt #8205 #8215

merged 2 commits into from Oct 14, 2022

Conversation

patricklx
Copy link
Contributor

resolves #8205

@patricklx
Copy link
Contributor Author

@runspired , maybe like this?

@runspired runspired added 🏷️ bug This PR primarily fixes a reported issue 🎯 release PR should be backported to release 🎯 canary PR is targeting canary (default) labels Oct 14, 2022
@patricklx patricklx closed this Oct 14, 2022
@patricklx patricklx reopened this Oct 14, 2022
@patricklx
Copy link
Contributor Author

@runspired tests mostly passed. the error in CI / additional-scenarios (with-ember-fetch-no-jquery) seems unrelated

@runspired runspired merged commit e4a08f7 into emberjs:master Oct 14, 2022
@patricklx patricklx deleted the patch-2 branch October 14, 2022 18:54
@patricklx
Copy link
Contributor Author

@runspired _createRecordData does not exist since 4.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runspired runspired runspired approved these changes

Assignees
No one assigned
Labels
🎯 canary PR is targeting canary (default) 🎯 release PR should be backported to release 🏷️ bug This PR primarily fixes a reported issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no models in ember inspector -> typesMapFor has no entries
2 participants
@patricklx @runspired