Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fast-push should adjust end based on start #8264

Merged
merged 1 commit into from Oct 29, 2022
Merged

Conversation

runspired
Copy link
Contributor

resolve #8263

@runspired runspired added 🎯 canary PR is targeting canary (default) 🏷️ bug This PR primarily fixes a reported issue ci-perf Activates Performance Checks in CI labels Oct 28, 2022
@github-actions
Copy link

Performance Report for 809deb5

Scenario - basic-record-materialization: ☑️ Performance is stable

☑️ duration
phase no difference [-9ms to 49ms]
☑️ Phase [navigationStart] => [start-data-generation]
phase no difference [-5ms to 2ms]
⚠️ Phase [start-data-generation] => [start-push-payload]
phase estimated regression +5ms [2ms to 8ms] OR +1.03% [0.46% to 1.63%]
☑️ Phase [start-push-payload] => [start-peek-records]
phase no difference [-4ms to 14ms]
☑️ Phase [start-peek-records] => [start-record-materialization]
phase no difference [0ms to 0ms]
☑️ Phase [start-record-materialization] => [end-record-materialization]
phase no difference [-4ms to 43ms]
☑️ Phase [end-record-materialization] => [Test End]
phase no difference [-4ms to 5ms]

Scenario - relationship-materialization-simple: ⚠️ Performance regressed

⚠️ duration
phase estimated regression +375ms [365ms to 385ms] OR +41.79% [40.66% to 42.87%]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-5ms to 2ms]
☑️ Phase [start-find-all] => [start-materialization]
phase no difference [-4ms to 5ms]
⚠️ Phase [start-materialization] => [end-materialization]
phase estimated regression +355ms [307ms to 365ms] OR +311.55% [269.24% to 320.57%]
⚠️ Phase [end-materialization] => [Test End]
phase estimated regression +10ms [7ms to 88ms] OR +25.47% [16.75% to 217.34%]

Scenario - relationship-materialization-complex: ⚠️ Performance regressed

⚠️ duration
phase estimated regression +31ms [3ms to 60ms] OR +0.58% [0.05% to 1.1%]
☑️ Phase [navigationStart] => [start-data-generation]
phase no difference [-2ms to 3ms]
☑️ Phase [start-data-generation] => [start-push-payload]
phase no difference [-2ms to 1ms]
☑️ Phase [start-push-payload] => [start-peek-records]
phase no difference [0ms to 14ms]
☑️ Phase [start-peek-records] => [start-record-materialization]
phase no difference [0ms to 0ms]
☑️ Phase [start-record-materialization] => [start-relationship-materialization]
phase no difference [-4ms to 5ms]
⚠️ Phase [start-relationship-materialization] => [end-relationship-materialization]
phase estimated regression +29ms [6ms to 51ms] OR +0.9% [0.18% to 1.6%]
☑️ Phase [end-relationship-materialization] => [Test End]
phase no difference [-3ms to 8ms]

Scenario - unload: ☑️ Performance is stable

☑️ duration
phase no difference [-10ms to 9ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-8ms to 8ms]
☑️ Phase [start-push-payload] => [start-unload-records]
phase no difference [-4ms to 6ms]
☑️ Phase [start-unload-records] => [end-unload-records]
phase no difference [-4ms to 1ms]
☑️ Phase [end-unload-records] => [Test End]
phase no difference [0ms to 0ms]

Scenario - unload-all: ☑️ Performance is stable

☑️ duration
phase no difference [-25ms to 7ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-4ms to 5ms]
☑️ Phase [start-push-payload] => [start-materialization]
phase no difference [-13ms to 3ms]
☑️ Phase [start-materialization] => [start-unload-all]
phase no difference [-4ms to 4ms]
☑️ Phase [start-unload-all] => [end-unload-all]
phase no difference [-8ms to 2ms]
✅ Phase [end-unload-all] => [Test End]
phase estimated improvement -1ms [-1ms to 0ms] OR -1.44% [-2.1% to -0.82%]

Scenario - destroy: ☑️ Performance is stable

☑️ duration
phase no difference [-15ms to 9ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-7ms to 11ms]
☑️ Phase [start-push-payload] => [start-destroy-records]
phase no difference [-7ms to 1ms]
☑️ Phase [start-destroy-records] => [end-destroy-records]
phase no difference [-4ms to 2ms]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [0ms to 1ms]

Scenario - add-children: ☑️ Performance is stable

☑️ duration
phase no difference [-4ms to 18ms]
☑️ Phase [navigationStart] => [start-push-initial-payload]
phase no difference [-8ms to 13ms]
⚠️ Phase [start-push-initial-payload] => [start-push-update-payload]
phase estimated regression +3ms [0ms to 5ms] OR +1.3% [0.12% to 2.49%]
☑️ Phase [start-push-update-payload] => [end-push-update-payload]
phase no difference [-2ms to 3ms]
☑️ Phase [end-push-update-payload] => [Test End]
phase no difference [0ms to 0ms]

Scenario - unused-relationships: ☑️ Performance is stable

☑️ duration
phase no difference [-17ms to 2ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-12ms to 3ms]
☑️ Phase [start-push-payload] => [end-push-payload]
phase no difference [-5ms to 2ms]
☑️ Phase [end-push-payload] => [Test End]
phase no difference [0ms to 0ms]

@runspired runspired merged commit 84b67a4 into master Oct 29, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-fast-push branch October 29, 2022 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-perf Activates Performance Checks in CI 🎯 canary PR is targeting canary (default) 🏷️ bug This PR primarily fixes a reported issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Ember Data 4.7] Models disappear when more than 2400 instances
1 participant