Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont skip LiveArray remove if pending queue is not empty #8306

Merged
merged 4 commits into from Nov 14, 2022

Conversation

runspired
Copy link
Contributor

resolves #8299

@runspired runspired added 🎯 release PR should be backported to release 🎯 canary PR is targeting canary (default) 🏷️ bug This PR primarily fixes a reported issue ci-perf Activates Performance Checks in CI labels Nov 14, 2022
@github-actions
Copy link

github-actions bot commented Nov 14, 2022

Performance Report for f823bfc

Scenario - basic-record-materialization: ☑️ Performance is stable

☑️ duration
phase no difference [-24ms to 9ms]
☑️ Phase [navigationStart] => [start-data-generation]
phase no difference [-2ms to 1ms]
☑️ Phase [start-data-generation] => [start-push-payload]
phase no difference [-1ms to 2ms]
☑️ Phase [start-push-payload] => [start-peek-records]
phase no difference [-9ms to 10ms]
☑️ Phase [start-peek-records] => [start-record-materialization]
phase no difference [0ms to 0ms]
☑️ Phase [start-record-materialization] => [end-record-materialization]
phase no difference [-10ms to 4ms]
☑️ Phase [end-record-materialization] => [Test End]
phase no difference [-1ms to 0ms]

Scenario - relationship-materialization-simple: ☑️ Performance is stable

☑️ duration
phase no difference [-8ms to 3ms]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-1ms to 2ms]
☑️ Phase [start-find-all] => [start-materialization]
phase no difference [-3ms to 1ms]
✅ Phase [start-materialization] => [end-materialization]
phase estimated improvement -8ms [-16ms to -1ms] OR -2.96% [-6.19% to -0.27%]
☑️ Phase [end-materialization] => [Test End]
phase no difference [-1ms to 3ms]

Scenario - relationship-materialization-complex: ☑️ Performance is stable

☑️ duration
phase no difference [-16ms to 18ms]
☑️ Phase [navigationStart] => [start-data-generation]
phase no difference [-1ms to 2ms]
☑️ Phase [start-data-generation] => [start-push-payload]
phase no difference [0ms to 1ms]
☑️ Phase [start-push-payload] => [start-peek-records]
phase no difference [-6ms to 1ms]
☑️ Phase [start-peek-records] => [start-record-materialization]
phase no difference [0ms to 0ms]
☑️ Phase [start-record-materialization] => [start-relationship-materialization]
phase no difference [-2ms to 2ms]
☑️ Phase [start-relationship-materialization] => [end-relationship-materialization]
phase no difference [-13ms to 17ms]
☑️ Phase [end-relationship-materialization] => [Test End]
phase no difference [-3ms to 4ms]

Scenario - unload: ☑️ Performance is stable

☑️ duration
phase no difference [-3ms to 6ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-2ms to 2ms]
☑️ Phase [start-push-payload] => [start-unload-records]
phase no difference [-1ms to 4ms]
☑️ Phase [start-unload-records] => [end-unload-records]
phase no difference [-1ms to 1ms]
☑️ Phase [end-unload-records] => [Test End]
phase no difference [0ms to 0ms]

Scenario - unload-all: ☑️ Performance is stable

☑️ duration
phase no difference [-7ms to 11ms]
✅ Phase [navigationStart] => [start-push-payload]
phase estimated improvement -2ms [-3ms to 0ms] OR -0.57% [-1.05% to -0.01%]
☑️ Phase [start-push-payload] => [start-materialization]
phase no difference [-1ms to 9ms]
☑️ Phase [start-materialization] => [start-unload-all]
phase no difference [-4ms to 1ms]
☑️ Phase [start-unload-all] => [end-unload-all]
phase no difference [-1ms to 4ms]
☑️ Phase [end-unload-all] => [Test End]
phase no difference [0ms to 0ms]

Scenario - destroy: ☑️ Performance is stable

☑️ duration
phase no difference [-5ms to 3ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [0ms to 3ms]
☑️ Phase [start-push-payload] => [start-destroy-records]
phase no difference [-2ms to 2ms]
☑️ Phase [start-destroy-records] => [end-destroy-records]
phase no difference [-3ms to 0ms]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [0ms to 0ms]

Scenario - add-children: ☑️ Performance is stable

☑️ duration
phase no difference [-6ms to 2ms]
☑️ Phase [navigationStart] => [start-push-initial-payload]
phase no difference [-4ms to 1ms]
☑️ Phase [start-push-initial-payload] => [start-push-update-payload]
phase no difference [-2ms to 1ms]
☑️ Phase [start-push-update-payload] => [end-push-update-payload]
phase no difference [-2ms to 1ms]
☑️ Phase [end-push-update-payload] => [Test End]
phase no difference [0ms to 0ms]

Scenario - unused-relationships: ☑️ Performance is stable

☑️ duration
phase no difference [-5ms to 2ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-1ms to 2ms]
☑️ Phase [start-push-payload] => [end-push-payload]
phase no difference [-4ms to 1ms]
☑️ Phase [end-push-payload] => [Test End]
phase no difference [0ms to 0ms]

@runspired runspired merged commit 2a9a25e into master Nov 14, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-8299 branch November 14, 2022 20:45
@icole icole added 🎯 lts The PR should be backported to the most recent LTS and removed 🎯 release PR should be backported to release labels Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-perf Activates Performance Checks in CI 🎯 canary PR is targeting canary (default) 🎯 lts The PR should be backported to the most recent LTS 🏷️ bug This PR primarily fixes a reported issue
Projects
None yet
2 participants