Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove proposal plugins and replace with their corresponding transform #489

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mansona
Copy link
Member

@mansona mansona commented Jul 6, 2023

plugin-proposal-class-properties, plugin-proposal-decorators, plugin-proposal-private-methods, and plugin-proposal-private-property-in-object are all now renamed to transform since they are out of proposal stage so this PR updates the dependencies 馃憤

@mansona
Copy link
Member Author

mansona commented Jul 11, 2023

So I noticed when the tests were failing that actually I missed some code that was trying to do smart stuff with ordering the plugins. I have pushed a really naive way to update that code but I have a seeking suspicion that we need to check for both the cases of "proposal" plugins and "transform" plugins, favouring the transform ones but catering for the case that people still use proposal ones 馃

Can someone with more context in this area let me know if they thing that is required?

@Windvis
Copy link

Windvis commented Aug 31, 2023

I think we can simply remove these plugins as they are part of preset-env v7.14+ (and we list 7.20 as a dependency): #501

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants