Publish Glint-ready type definitions #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since these are not actively recommended, I am not taking the time to actively reimplement the package as TypeScript, but we *do* need types for these in the ecosystem. These use `@glint/template` as a peer and dev dependencies, and supply custom generic types using `ModifierLike` rather than using the types from `ember-modifier` since these modifiers use custom modifier managers instead.
chriskrycho
force-pushed
the
types
branch
2 times, most recently
from
917da97
to
88f96da
Compare
Since these are not actively recommended, I am not taking the time to actively reimplement the package as TypeScript, but we *do* need types for these in the ecosystem. These use `@glint/template` as a peer and dev dependencies, and supply custom generic types using `ModifierLike` rather than using the types from `ember-modifier` since these modifiers use custom modifier managers instead.
Co-authored-by: V. Lascik <vlascik@users.noreply.github.com>
chriskrycho
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since these are not actively recommended, I am not taking the time to actively reimplement the package as TypeScript, but we do need types for these in the ecosystem. These use
@glint/templateas a peer and dev dependencies, and supply custom generic types usingModifierLikerather than using the types fromember-modifiersince these modifiers use custom modifier managers instead.Closes #69.