Fix the way the pending requests module is used in settled.ts #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raycohen
commented
Dec 2, 2021
| @@ -44,20 +49,16 @@ if (typeof jQuery !== 'undefined' && _internalPendingRequests) { | |||
| // This can be removed once Ember 4.0.0 is released | |||
| EmberApplicationInstance.reopen({ | |||
| willDestroy(...args: any[]) { | |||
| const internalPendingRequests = _internalPendingRequests(); | |||
|
|
|||
| if (internalPendingRequests !== 0) { | |||
There was a problem hiding this comment.
the outer if statement checks that _internalPendingRequestsModule exists, which I believe makes calling off and clearPendingRequests here safe and desirable regardless of what the PendingRequestsCount is
raycohen
force-pushed
the
raycohen/fix-pending-requests-use-in-app-will-destroy
branch
from
67f0ade
to
3e98c2f
Compare
rwjblue
approved these changes
Jan 11, 2022
|
Would it be possible to cut a release that includes this change? |
|
@rwjblue any chance we can get a release with this 🙏 |
|
oh dear, sorry y'all; I thought I had already released it 😭 |
|
Finally released in 2.6.2 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1172
Related to #1047
Before these changes, the code is confusing a module with one of the functions on that module.