test(fillIn,typeIn): account for selectionchange in Firefox
#1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buschtoens
commented
Feb 27, 2022
Comment on lines
+9
to
+10
| // Unlike Chrome, Firefox emits `selectionchange` events. | ||
| export const isFirefox = navigator.userAgent.indexOf('Firefox') >= 0; |
There was a problem hiding this comment.
I wanted to do a proper feature detection instead of resorting to user agent parsing, but unfortunately that would have required async code, which is not possible here.
There was a problem hiding this comment.
We could do it async, and have tests/test-helper.js call the function before calling start() to kick off the tests...
buschtoens
force-pushed
the
tests-firefox
branch
from
a45d31a
to
0a1245e
Compare
rwjblue
reviewed
Mar 31, 2022
| @@ -226,7 +228,8 @@ module('DOM Helper: fillIn', function (hooks) { | |||
| await setupContext(context); | |||
| await fillIn(element, 'foo'); | |||
|
|
|||
| assert.verifySteps(clickSteps); | |||
| // For this specific case, Firefox does not emit `selectionchange`. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for
fillInandtypeInare failing in Firefox, because it emits aselectionchangeevent, unlike Chrome.This conditionally adds
selectionchangeto the list of expected events, similar to how Internet Explorer is handled already.