Fix usage of owner.unregister within ember-engines tests
#1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buschtoens
force-pushed
the
fix-owner-unregister
branch
from
5341621
to
ddf200a
Compare
rwjblue
changed the title
unregister calls container.resetowner.unregister within ember-engines tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
buildOwneris used with aresolverinstead of anapplication, a custom owner is constructed via-internal/build-registry.tsand used instead of anApplicationInstance.This custom owner misses the
unregisterpatch that was added in emberjs/ember.js#12680 to fix emberjs/ember.js#11173 (comment). It is now on theEngineInstance.Fixes buschtoens/ember-link#714.