Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get ember-canary passing #1360

Merged
merged 2 commits into from
Apr 5, 2023
Merged

Get ember-canary passing #1360

merged 2 commits into from
Apr 5, 2023

Conversation

NullVoxPopuli
Copy link
Sponsor Collaborator

@NullVoxPopuli NullVoxPopuli commented Mar 24, 2023

Per: emberjs/ember.js#20418

Canary tests were hanging,
Locally:

Died on test #1: Could not find module `@ember/polyfills` imported from `dummy/tests/unit/setup-context-test`
    at TestLoader.moduleLoadFailure (http://localhost:4202/assets/tests.js:1184:22)
    at TestLoader.require (http://localhost:4202/assets/test-support.js:6931:14)
    at TestLoader.loadModules (http://localhost:4202/assets/test-support.js:6923:14)

To fix, I had to remove @ember/polyfills -- which would be a breaking change -- but that's fine, as we're preparing for v3 anyway

@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review March 25, 2023 02:12
@kategengler kategengler merged commit e75a3cf into emberjs:master Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants