-
-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2 conversion #1381
Draft
NullVoxPopuli
wants to merge
13
commits into
emberjs:master
Choose a base branch
from
NullVoxPopuli:v2-conversion
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
V2 conversion #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
force-pushed
the
v2-conversion
branch
from
May 2, 2023 01:42
8412cea
to
76fb057
Compare
…d we dodn't use the types, but keep the peer
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to see what is blocking while doing the whole conversion in one go
Pending
upstream patchesThings preserved:
Breaking changes:
setResolver
assetApplication
already sets up an event-dispatcher, and for complexity reasons, support for custom event dispatcher has been removed increateCustomResolver
Non-Breaking changes:
once all core ember addons are v2, we can much more easily do vite/vitest tests in non-monorepo repos (lots of cool things are unlocked once we drop broccoli / v1 addons entirely -- single-repos become an option again!).