Remove 2 requires #1383
Open
Remove 2 requires #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NullVoxPopuli looks like this is still in draft mode or do you intend for it to be merged? |
|
It is intended to be merged, apologies |
ef4
reviewed
May 9, 2023
addon/addon-test-support/@ember/test-helpers/-internal/build-registry.ts
Show resolved
Hide resolved
ef4
reviewed
May 9, 2023
| @@ -16,7 +16,6 @@ export default function ajax(url) { | |||
| }); | |||
| }); | |||
| } else { | |||
| let fetch = require('fetch').default; | |||
| return fetch(url).then((response) => response.text()); | |||
| return waitForPromise(fetch(url).then((response) => response.text())); | |||
There was a problem hiding this comment.
Are we sure this doesn't break fastboot?
I'm all in favor of switching to global fetch everywhere, but doing that correctly requires some work to make sure the global fetch does all the things that require('fetch') has been doing.
There was a problem hiding this comment.
We can do the monorepo conversion first, and add a fastboot-using test app to be sure.
…V2 conversion branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
require is private API to this package, and we have build-time tools via
@embroider/macros