Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Correctly associate props with factory and owner in FactoryManager
Previously, we stomped the `props` binding with an `Object.assign()`, which meant that the original empty props object would get GC'd after the end of the method and the item passed into the class created at the end of the `FactoryManager.create` call would be a *different* object, which does *not* have the factory or owner associations. Fixes #20023
- Loading branch information
1 parent
d8f8266
commit 0b154e7
Showing
3 changed files
with
8 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters