Skip to content

Commit

Permalink
Merge pull request #20024 from emberjs/chriskrycho/fix-FactoryManager…
Browse files Browse the repository at this point in the history
….create

[BUGFIX lts] Correctly associate props with factory and owner in FactoryManager
  • Loading branch information
chriskrycho committed Mar 16, 2022
2 parents d8f8266 + d79edb3 commit 4fdb67c
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions packages/@ember/-internals/container/lib/container.ts
Expand Up @@ -504,14 +504,10 @@ export class FactoryManager<T, C extends FactoryClass | object = FactoryClass> {
);
}

let props = {};
let props = options ? { ...options } : {};
setOwner(props, container.owner!);
setFactoryFor(props, this);

if (options !== undefined) {
props = Object.assign({}, props, options);
}

if (DEBUG) {
let lazyInjections;
let validationCache = this.container.validationCache;
Expand Down

0 comments on commit 4fdb67c

Please sign in to comment.