Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX lts] Prevent <base target="_parent"> from erroring in HistoryLocation #19059

Merged
merged 1 commit into from Jul 29, 2020

Commits on Jul 29, 2020

  1. [BUGFIX lts] Prevent <base target="_parent"> from erroring in Histo…

    …ryLocation
    
    It is perfectly valid to have a `<base>` element without an `href`
    attribute but the code previously assumed that if a `<base>` was present
    that it **must** contain an `href`.
    
    Specifically, prior to this change if you had a `<base>` like:
    
    ```html
    <base target="_parent">
    ```
    
    You would get the following error:
    
    ```
    Uncaught TypeError: Cannot read property 'replace' of null
    ```
    
    See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/base for
    more details on usage of `<base>` without an `href`.
    rwjblue committed Jul 29, 2020
    Copy the full SHA
    46b7aad View commit details
    Browse the repository at this point in the history